Narcasung/Questie-X
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(minimap): remove 1241 special-case overlay from drawMinimapPin

Browse Source 
The uiMapID==1241 branch in drawMinimapPin was an experimental overlay
that ran BEFORE the standard minimap projection and rotation transforms.
It duplicated the projection math while bypassing the rotation matrix,
used a different edge-clamp path, and is the primary suspect for why
pins visually follow the player on Sunstrider Isle.

The standard minimap path (handle rotation -> adapt delta to mapRadius
-> apply shape mask -> float-on-edge or clamp) already handles all
pins uniformly regardless of zone. Removing this experimental branch
lets 1241 pins use the same proven path as every other zone.

Also cleaned up:
- stale lastInstanceId reference in throttled PIN debug trace
- unnecessary data.uiMapID guard in QuestieDebugMinimapPin gate
- Sunstrider-specific minimap debug block in UpdateMinimapPins
This commit is contained in:
Xurkon
2026-05-30 14:27:09 -05:00
parent 72b924c514
commit 039bdf3627
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Compat/HBD.lua
+3 -3
View File
@@ -425,13 +425,13 @@ local function drawMinimapPin(pin, data)
local xDist, yDist = lastXY - data.x, lastYY - data.y local xDist, yDist = lastXY - data.x, lastYY - data.y
-- Throttled debug: print once per second max -- Throttled debug: print once per second max
if _G.QuestieDebugMinimapPin and data.uiMapID and (not _G._QDPinDebugTime or (GetTime() - _G._QDPinDebugTime) > 1) then if _G.QuestieDebugMinimapPin and (not _G._QDPinDebugTime or (GetTime() - _G._QDPinDebugTime) > 1) then
_G._QDPinDebugTime = GetTime() _G._QDPinDebugTime = GetTime()
local finalX = (xDist / (mapRadius or 1)) * minimapWidth local finalX = (xDist / (mapRadius or 1)) * minimapWidth
local finalY = (yDist / (mapRadius or 1)) * minimapHeight local finalY = (yDist / (mapRadius or 1)) * minimapHeight
print(string.format( print(string.format(
"[QD] PIN uiMap=%s inst=%s/%s pinW=(%.2f,%.2f) playerW=(%.2f,%.2f) dist=(%.2f,%.2f) mapRad=%.1f scale=(%.4f,%.4f) final=(%.2f,%.2f)", "[QD] PIN uiMap=%s inst=%s pinW=(%.2f,%.2f) playerW=(%.2f,%.2f) dist=(%.2f,%.2f) mapRad=%.1f scale=(%.4f,%.4f) final=(%.2f,%.2f)",
tostring(data.uiMapID), tostring(data.instanceID), tostring(lastInstanceId), tostring(data.uiMapID), tostring(data.instanceID),
data.x, data.y, lastXY, lastYY, data.x, data.y, lastXY, lastYY,
xDist, yDist, mapRadius or -1, xDist, yDist, mapRadius or -1,
xDist / (mapRadius or 1), yDist / (mapRadius or 1), xDist / (mapRadius or 1), yDist / (mapRadius or 1),