From 211bc5be844f255524dcedd5aba5432f5eb2be3d Mon Sep 17 00:00:00 2001
From: Xurkon <36556990+Xurkon@users.noreply.github.com>
Date: Sat, 21 Feb 2026 11:17:37 -0600
Subject: [PATCH] Fix arrow pointing to key-drop NPC after quest complete

GetAllQuestIds called CheckQuestSourceItem(questId, true) for all
non-failed quests. When a consumable key is used and leaves the bag,
this created a fake 'get the item' objective pointing to the drop NPC
even when the quest was already complete (complete == 1).

Guard the call: only run CheckQuestSourceItem when complete != 1.
Complete quests route through PopulateObjectiveNotes which correctly
shows the finisher instead.
---
 Modules/Quest/QuestieQuest.lua | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/Modules/Quest/QuestieQuest.lua b/Modules/Quest/QuestieQuest.lua
index a5744cc..949ced1 100644
--- a/Modules/Quest/QuestieQuest.lua
+++ b/Modules/Quest/QuestieQuest.lua
@@ -778,7 +778,12 @@ function QuestieQuest:GetAllQuestIds()
             if complete == -1 then
                 QuestieQuest:UpdateQuest(questId)
             else
-                QuestieQuest:CheckQuestSourceItem(questId, true)
+                -- Only draw the source item objective when the quest is not yet complete.
+                -- If the quest is complete (complete == 1), the source item was consumed during
+                -- the quest (e.g. Cold Iron Key for quest 12843) and should not draw its drop NPC.
+                if complete ~= 1 then
+                    QuestieQuest:CheckQuestSourceItem(questId, true)
+                end
                 QuestieQuest:PopulateQuestLogInfo(quest)
 
                 if QuestieQuest:ShouldShowQuestNotes(questId) then