From 301d7185fbfad1ed27246cb87e2153e4161b1e77 Mon Sep 17 00:00:00 2001 From: Xurkon Date: Wed, 18 Mar 2026 23:16:02 -0500 Subject: [PATCH] release: v1.3.6 --- CHANGELOG.md | 6 ++++++ Modules/WorldMapTaintWorkaround.lua | 24 ++++++++++++------------ Questie-X-Classic.toc | 2 +- Questie-X-TBC.toc | 2 +- Questie-X-Turtle.toc | 2 +- Questie-X.toc | 2 +- docs/changelog.html | 7 +++++++ 7 files changed, 29 insertions(+), 16 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 406cddd..ca5985f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,11 @@ # Changelog +## v1.3.6 — Tooltip Fixes & Enhanced Taint Workaround + +- **[Quest Progress]** Resolved an issue where quest tooltips would not reliably update their progress counts when dynamically learning AI spawns or during rapid kill credit updates. +- **[Taint Workaround]** Reinforced the `WorldMapTaintWorkaround` for older WoW clients (3.3.5) by correcting the `IsAddOnLoaded` detection timing and adding explicit empty-function stubs to blocked dropdowns. +- **[Diagnostics]** Improved error reporting for global variable collisions during module initialization. + ## v1.3.5 — Comprehensive Taint & Architecture Fixes *A comprehensive update resolving 13 distinct issues related to global environment taint, unsafe polyfills, and module stability across all supported Lua environments (5.0, 5.1, 5.2).* diff --git a/Modules/WorldMapTaintWorkaround.lua b/Modules/WorldMapTaintWorkaround.lua index eb455f7..1d98c19 100644 --- a/Modules/WorldMapTaintWorkaround.lua +++ b/Modules/WorldMapTaintWorkaround.lua @@ -4,34 +4,34 @@ local function doWorkaround() -- Blizzard's bugs -- https://github.com/Stanzilla/WoWUIBugs/issues/114 and https://github.com/Stanzilla/WoWUIBugs/issues/165 - -- HDB (and Questie fork of it) uses WorldMapFrame:AddDataProvider( ). - -- print("|cff30fc96Questie|r: |cff00bc32Hiding drop-down menus on the World Map.|r This is currently necessary as a workaround for a bug in the default Blizzard UI related to drop-down menus.") + -- HDB (and Questie fork of it) uses WorldMapFrame:AddDataProvider(). + -- Reassigning the _Update functions (e.g. WorldMapContinentDropDown_Update = function() end) + -- BEFORE any calls are made is often more reliable than only Hiding the frame. + if WorldMapZoneMinimapDropDown then WorldMapZoneMinimapDropDown:Hide() + WorldMapZoneMinimapDropDown.Update = function() end end if WorldMapContinentDropDown then - -- We only Hide() these frames. - -- Reassigning the _Update functions (e.g. WorldMapContinentDropDown_Update = function() end) - -- would cause Taint, which results in ADDON_ACTION_BLOCKED: UseAction(). WorldMapContinentDropDown:Hide() + WorldMapContinentDropDown.Update = function() end end if WorldMapZoneDropDown then WorldMapZoneDropDown:Hide() + WorldMapZoneDropDown.Update = function() end end - --WorldMapMagnifyingGlassButton:Hide() end -local _, finished = IsAddOnLoaded("Blizzard_WorldMap") - -if finished then +-- IsAddOnLoaded on 3.3.5 returns 1 or nil, not two values. +-- If loaded, run immediately, else wait for ADDON_LOADED. +if IsAddOnLoaded("Blizzard_WorldMap") then doWorkaround() else local f = CreateFrame("Frame") - local function addonLoaded(_, _, addOnName) + f:SetScript("OnEvent", function(_, _, addOnName) if addOnName == "Blizzard_WorldMap" then doWorkaround() end - end - f:SetScript("OnEvent", addonLoaded) + end) f:RegisterEvent("ADDON_LOADED") end diff --git a/Questie-X-Classic.toc b/Questie-X-Classic.toc index 356c01c..cf683a7 100644 --- a/Questie-X-Classic.toc +++ b/Questie-X-Classic.toc @@ -5,7 +5,7 @@ ## Notes-esES: Ayundante de misión ## Notes-ptBR: Ajudante de missão ## Notes-frFR: Assistant de quête -## Version: 1.3.5 +## Version: 1.3.6 ## RequiredDeps: ## OptionalDeps: Ace3, CallbackHandler-1.0, HereBeDragons, LibDataBroker-1.1, LibDBIcon-1.0, LibSharedMedia-3.0, LibStub, LibUIDropDownMenu ## SavedVariables: QuestieConfig diff --git a/Questie-X-TBC.toc b/Questie-X-TBC.toc index 3a183a5..6e6f37c 100644 --- a/Questie-X-TBC.toc +++ b/Questie-X-TBC.toc @@ -5,7 +5,7 @@ ## Notes-esES: Ayundante de misión ## Notes-ptBR: Ajudante de missão ## Notes-frFR: Assistant de quête -## Version: 1.3.5 +## Version: 1.3.6 ## RequiredDeps: ## OptionalDeps: Ace3, CallbackHandler-1.0, HereBeDragons, LibDataBroker-1.1, LibDBIcon-1.0, LibSharedMedia-3.0, LibStub, LibUIDropDownMenu ## SavedVariables: QuestieConfig diff --git a/Questie-X-Turtle.toc b/Questie-X-Turtle.toc index e846f45..480dbad 100644 --- a/Questie-X-Turtle.toc +++ b/Questie-X-Turtle.toc @@ -5,7 +5,7 @@ ## Notes-esES: Ayundante de misión ## Notes-ptBR: Ajudante de missão ## Notes-frFR: Assistant de quête -## Version: 1.3.5 +## Version: 1.3.6 ## RequiredDeps: ## OptionalDeps: Ace3, CallbackHandler-1.0, HereBeDragons, LibDataBroker-1.1, LibDBIcon-1.0, LibSharedMedia-3.0, LibStub, LibUIDropDownMenu, Questie-X-TurtleDB ## SavedVariables: QuestieConfig diff --git a/Questie-X.toc b/Questie-X.toc index 9fb9d52..4fe2780 100644 --- a/Questie-X.toc +++ b/Questie-X.toc @@ -11,7 +11,7 @@ ## Notes-esES: Ayundante de misión ## Notes-ptBR: Ajudante de missão ## Notes-frFR: Assistant de quête -## Version: 1.3.5 +## Version: 1.3.6 ## RequiredDeps: ## OptionalDeps: Ace3, CallbackHandler-1.0, HereBeDragons, LibDataBroker-1.1, LibDBIcon-1.0, LibSharedMedia-3.0, LibStub, LibUIDropDownMenu, Questie-X-WotLKDB, Questie-X-ClassicDB, Questie-X-TBCDB, Questie-X-TurtleDB, Questie-X-AscensionDB, Questie-X-EbonholdDB ## SavedVariables: QuestieConfig, QuestieLearnerDB diff --git a/docs/changelog.html b/docs/changelog.html index d7f65a9..e805626 100644 --- a/docs/changelog.html +++ b/docs/changelog.html @@ -176,6 +176,13 @@
+

v1.3.6 — Tooltip Fixes & Enhanced Taint Workaround

+ +

v1.3.5 — Comprehensive Taint & Architecture Fixes

A comprehensive update resolving 13 distinct issues related to global environment taint, unsafe polyfills, and module stability across all supported Lua environments (5.0, 5.1, 5.2).