From 49ef9b6e55162629207d95c5cb1e2d7657cdc2de Mon Sep 17 00:00:00 2001
From: Xurkon <Kancerous@gmail.com>
Date: Thu, 2 Apr 2026 20:51:08 -0500
Subject: [PATCH] fix: Use pairs() instead of ipairs() for hash table iteration

---
 .../Options/ArrowTab/QuestieOptionsArrow.lua  | 36 +++++++++----------
 .../TrackerTab/QuestieOptionsTracker.lua      | 36 +++++++++----------
 2 files changed, 36 insertions(+), 36 deletions(-)

diff --git a/Modules/Options/ArrowTab/QuestieOptionsArrow.lua b/Modules/Options/ArrowTab/QuestieOptionsArrow.lua
index 969e4ce..bfe31f1 100644
--- a/Modules/Options/ArrowTab/QuestieOptionsArrow.lua
+++ b/Modules/Options/ArrowTab/QuestieOptionsArrow.lua
@@ -18,29 +18,29 @@ local SharedMedia = LibStub("LibSharedMedia-3.0")
 -- Build expanded font list from SharedMedia + common WoW fonts
 local function GetExpandedFontList()
     local fonts = {}
-    -- Add SharedMedia fonts
-    for _, name in ipairs(SharedMedia:HashTable("font")) do
+    -- Add SharedMedia fonts (HashTable returns key-value table)
+    for name, _ in pairs(SharedMedia:HashTable("font")) do
         fonts[name] = name
     end
     -- Add common WoW fonts not typically in SharedMedia
     local wowFonts = {
-        ["Friz Quadrata TT"] = "Friz Quadrata TT",
-        ["Friz Quadrata"] = "Friz Quadrata",
-        ["Arial Narrow"] = "Arial Narrow",
-        ["Arial"] = "Arial",
-        ["Skull"] = "Skull",
-        ["Number Font"] = "Number Font",
-        ["GameFontHighlight"] = "GameFontHighlight",
-        ["GameFontNormal"] = "GameFontNormal",
-        ["GameFontBold"] = "GameFontBold",
-        ["GameFontLarge"] = "GameFontLarge",
-        ["GameFontNormalSmall"] = "GameFontNormalSmall",
-        ["ChatFontNormal"] = "ChatFontNormal",
-        ["QuestFont"] = "QuestFont",
-        ["QuestFont_Large"] = "QuestFont_Large",
-        ["DialogNormal"] = "DialogNormal",
+        ["Friz Quadrata TT"] = true,
+        ["Friz Quadrata"] = true,
+        ["Arial Narrow"] = true,
+        ["Arial"] = true,
+        ["Skull"] = true,
+        ["Number Font"] = true,
+        ["GameFontHighlight"] = true,
+        ["GameFontNormal"] = true,
+        ["GameFontBold"] = true,
+        ["GameFontLarge"] = true,
+        ["GameFontNormalSmall"] = true,
+        ["ChatFontNormal"] = true,
+        ["QuestFont"] = true,
+        ["QuestFont_Large"] = true,
+        ["DialogNormal"] = true,
     }
-    for _, name in ipairs(wowFonts) do
+    for name, _ in pairs(wowFonts) do
         fonts[name] = name
     end
     return fonts
diff --git a/Modules/Options/TrackerTab/QuestieOptionsTracker.lua b/Modules/Options/TrackerTab/QuestieOptionsTracker.lua
index 40e4c79..b99924a 100644
--- a/Modules/Options/TrackerTab/QuestieOptionsTracker.lua
+++ b/Modules/Options/TrackerTab/QuestieOptionsTracker.lua
@@ -32,29 +32,29 @@ local SharedMedia = LibStub("LibSharedMedia-3.0")
 -- Build expanded font list from SharedMedia + common WoW fonts
 local function GetExpandedFontList()
     local fonts = {}
-    -- Add SharedMedia fonts
-    for _, name in ipairs(SharedMedia:HashTable("font")) do
+    -- Add SharedMedia fonts (HashTable returns key-value table)
+    for name, _ in pairs(SharedMedia:HashTable("font")) do
         fonts[name] = name
     end
     -- Add common WoW fonts not typically in SharedMedia
     local wowFonts = {
-        ["Friz Quadrata TT"] = "Friz Quadrata TT",
-        ["Friz Quadrata"] = "Friz Quadrata",
-        ["Arial Narrow"] = "Arial Narrow",
-        ["Arial"] = "Arial",
-        ["Skull"] = "Skull",
-        ["Number Font"] = "Number Font",
-        ["GameFontHighlight"] = "GameFontHighlight",
-        ["GameFontNormal"] = "GameFontNormal",
-        ["GameFontBold"] = "GameFontBold",
-        ["GameFontLarge"] = "GameFontLarge",
-        ["GameFontNormalSmall"] = "GameFontNormalSmall",
-        ["ChatFontNormal"] = "ChatFontNormal",
-        ["QuestFont"] = "QuestFont",
-        ["QuestFont_Large"] = "QuestFont_Large",
-        ["DialogNormal"] = "DialogNormal",
+        ["Friz Quadrata TT"] = true,
+        ["Friz Quadrata"] = true,
+        ["Arial Narrow"] = true,
+        ["Arial"] = true,
+        ["Skull"] = true,
+        ["Number Font"] = true,
+        ["GameFontHighlight"] = true,
+        ["GameFontNormal"] = true,
+        ["GameFontBold"] = true,
+        ["GameFontLarge"] = true,
+        ["GameFontNormalSmall"] = true,
+        ["ChatFontNormal"] = true,
+        ["QuestFont"] = true,
+        ["QuestFont_Large"] = true,
+        ["DialogNormal"] = true,
     }
-    for _, name in ipairs(wowFonts) do
+    for name, _ in pairs(wowFonts) do
         fonts[name] = name
     end
     return fonts