diff --git a/CHANGELOG.md b/CHANGELOG.md index 2b37488..59833eb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,11 +2,12 @@ ## v1.3.4 — Taint Analysis & Error Fixes -*Resolves the `l10n` initialization error in `GameVersionError.lua` and confirms the integrity of the WotLKDB module after a deep taint analysis.* +*Resolves the initialization error in `GameVersionError.lua` and implements a version guard to support Classic-era private servers. Also confirms the integrity of the WotLKDB module after a deep taint analysis.* ### Core & Stability -- **[Fix]** Resolved `attempt to call local 'l10n' (a table value)` in `GameVersionError.lua` by using hardcoded English strings for early-load error messages. +- **[Fix]** Resolved `attempt to call local 'l10n' (a table value)` in `GameVersionError.lua` and implemented a `tocVersion` guard to prevent the "unsupported client" error on Classic-era private servers (e.g., Turtle WoW). +- **[Fix]** Updated `GameVersionError.lua` strings to correctly identify Questie-X as supporting Classic and private servers. - **[Taint Analysis]** Completed a full audit of `Questie-X-WotLKDB`. No direct taint vectors or secure function overrides were found. - **[Version Sync]** Synchronized versions to v1.3.4 across all components. diff --git a/Modules/GameVersionError.lua b/Modules/GameVersionError.lua index 810e58f..9dd5e17 100644 --- a/Modules/GameVersionError.lua +++ b/Modules/GameVersionError.lua @@ -1,22 +1,28 @@ ---@type l10n local l10n = QuestieLoader:ImportModule("l10n") +local _, _, _, tocVersion = GetBuildInfo() +if tocVersion and tocVersion < 50000 then + -- This is a Classic-era client (Turtle, Era, WotLK, etc.) + return +end + -- No timeres or other fancy stuff as 1.12 client is very limited. -- StaticPopup has very limited width, so text is split to many lines. local msg = { - "You're trying to use Questie addon", + "You're trying to use Questie-X", "on an unsupported WoW game client!", - "WoW \"retail\" and private servers", - "are not supported.", + "WoW \"retail\" is NOT supported.", + "Please use a Classic-era client.", - "Questie only supports", - "WoW Classic (Era/Wrath)!", + "Questie-X only supports", + "WoW Classic (Vanilla/TBC/Wrath)!", } StaticPopupDialogs["QUESTIE_VERSION_ERROR"] = { - text = "|cffff0000ERROR|r\n" .. msg[1] .. "\n" .. msg[2] .. "\n\n" .. msg[3] .. "\n" .. msg[4] .. "\n\n" .. msg[5] .. "\n" .. msg[6], + text = "|cffff0000ERROR|r\n" .. msg[1] .. "\n" .. msg[2] .. "\n\n" .. msg[3] .. "\n" .. msg[4] .. "\n\n" .. msg[5] .. " " .. msg[6], button2 = "OK", hasEditBox = false, whileDead = true diff --git a/docs/changelog.html b/docs/changelog.html index e7c22bd..d907e24 100644 --- a/docs/changelog.html +++ b/docs/changelog.html @@ -177,11 +177,12 @@

v1.3.4 — Taint Analysis & Error Fixes

-

Resolves the l10n initialization error in GameVersionError.lua and confirms the integrity of the WotLKDB module after a deep taint analysis.

+

Resolves the initialization error in GameVersionError.lua and implements a version guard to support Classic-era private servers. Also confirms the integrity of the WotLKDB module after a deep taint analysis.

Core & Stability