Narcasung/Questie-X
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(map): unload completed-objective pins deterministically

Browse Source 
Completed objectives could leave their map/minimap pins on screen until
turn-in. Pin removal relied solely on _UnloadAlreadySpawnedIcons, which
walks objective.AlreadySpawned; that table desyncs from the live frames
after learner spawn-list invalidation or complete->abandon->reaccept
cycles, so when reset to {} the frames leaked.

Add QuestieMap:UnloadQuestFramesForObjective(questId, objectiveIndex)
which unloads frames off the map's own questIdFrames registry by matching
frame.data.ObjectiveIndex, and call it from every completion path in
PopulateObjective. Restricted to positive standard-objective indices;
SpecialObjectives (sentinel index 0) keep using AlreadySpawned.
This commit is contained in:
Xurkon
2026-06-09 17:01:34 -05:00
parent bd16c59681
commit 8137d90ff6
3 changed files with 26 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Modules/Map/QuestieMap.lua
+22
View File
@@ -85,6 +85,28 @@ function QuestieMap:GetFramesForQuest(questId)
return frames
end
-- Unload only the frames belonging to a single objective of a quest.
-- Frames carry data.ObjectiveIndex (set in _DetermineIconsToDraw), so we can remove a
-- completed objective's pins deterministically off the map's own frame registry instead
-- of relying on objective.AlreadySpawned, which desyncs from on-screen frames after
-- learner spawn-list invalidation or complete->abandon->reaccept cycles.
function QuestieMap:UnloadQuestFramesForObjective(questId, objectiveIndex)
-- objectiveIndex 0 is the SpecialObjectives sentinel (shared by all special objectives),
-- so unloading by it would cross-remove sibling specials mid-pass. Only act on real
-- positive standard-objective indices; specials keep using AlreadySpawned.
if (not objectiveIndex) or objectiveIndex <= 0 or (not QuestieMap.questIdFrames[questId]) then
return
end
for name, frame in pairs(QuestieMap:GetFramesForQuest(questId)) do
if frame and frame.data and frame.data.ObjectiveIndex == objectiveIndex then
frame:Unload()
QuestieMap.questIdFrames[questId][name] = nil
_G[name] = nil
end
end
Questie:Debug(Questie.DEBUG_DEVELOP, "[QuestieMap] Unloading objective frames for questid:", questId, "objIdx:", objectiveIndex)
end
function QuestieMap:UnloadQuestFrames(questId, iconType)
if QuestieMap.questIdFrames[questId] then
if not iconType then