fix(tooltip): make ElvUI tooltip style opt-in, reset for existing installs (#16)
The ElvUI tooltip style shipped on by default, so Questie restyled every default WoW tooltip (stripping the border) for users who never asked for it and don't run ElvUI. Default is now false, plus migration [8] resets it off once for existing profiles.
This commit is contained in:
@@ -40,6 +40,7 @@
|
||||
|
||||
### Bug Fixes
|
||||
|
||||
- **[Tooltip - ElvUI Style No Longer On By Default]** (#16) The "ElvUI tooltip style" option shipped enabled by default, so Questie restyled every default WoW tooltip — stripping the border — for users who never asked for it and don't run ElvUI. It is now opt-in (default off), and a one-time migration resets it off for existing installs so their default tooltips return. Users who want the flat style can re-enable it in the General tab.
|
||||
- **[Quest - Turned-In Quests Misclassified As Abandoned]** (#9) On Ascension some turn-ins (notably crafting/auto-complete quests) fire `QUEST_REMOVED` without a preceding `QUEST_TURNED_IN`, so Questie's 1-second abandon timer ran `MarkQuestAsAbandoned`. By then `QuestLogCache.RemoveQuest` had already cleared the quest, so the `IsComplete` check returned 0 and the *turned-in* quest was treated as abandoned — leaving its objective pins and turn-in `?` lingering on the map and minimap. The completion state is now snapshotted at `QUEST_REMOVED` time (while the quest is still in the cache) and used by the abandon timer, so a quest that was complete at removal is correctly completed (pins/`?` cleared) rather than abandoned.
|
||||
- **[Map - Minimap Range Cutoff No Longer Clips Visible Icons]** (#17) The "Minimap Icon Range Cutoff" added in a prior build hid every quest icon beyond its yard value *before* checking whether the icon was within the minimap's visible circle. Because the minimap's view radius is 133–466 yards depending on zoom, a cutoff of 100 (the default) hid icons that were clearly on the minimap — they only appeared once the player was very close. The cutoff now only clips icons that fall *outside* the minimap's visible radius: in HBD's pin renderer it is gated on `dist > 1` (outside the visible circle), and in `QuestieMap`'s minimap `FadeLogic` the effective cutoff is raised to at least the current minimap view radius (read from the new `HBDPins:GetMinimapRadius()`). Icons within the visible minimap always show again; the cutoff still controls how far edge-floating icons reach for far-apart objectives when zoomed out.
|
||||
- **[Tooltip - Stop Eating ID Lines & Other Addons' Tooltip Text]** `HideAscensionQuestLines` (which hides Ascension's injected quest-objective progress text from tooltips) was too greedy: once it found an objective line (e.g. `0/8 Arcane Wraith slain`) it kept hiding every following non-indented line until an indented one. Because Questie's own `Item ID`/`NPC ID`/`Object ID` lines and other addons' additions (e.g. an item-count overlay) are appended at the *bottom* of the tooltip — after the objective block — a refresh pass wiped them too, so the ID you needed to report data never showed. It now hides only the lines that themselves match an Ascension objective pattern (`N/M`, `[N] ...`, `- N/M ...`) and never the trailing lines, so IDs and other addons' text are left intact.
|
||||
|
||||
@@ -119,6 +119,13 @@ local migrationFunctions = {
|
||||
if Questie.db and Questie.db.global and Questie.db.global.learnedData then
|
||||
Questie.db.global.learnedData = nil
|
||||
end
|
||||
end,
|
||||
[8] = function()
|
||||
-- The "ElvUI style tooltips" option shipped enabled by default, which made Questie
|
||||
-- restyle every default WoW tooltip (stripping the border) for users who never asked
|
||||
-- for it (#16). It is now opt-in (default false). Reset it off once so existing installs
|
||||
-- get their default tooltips back; users who want the flat style can re-enable it.
|
||||
Questie.db.profile.elvuiStyleTooltips = false
|
||||
end
|
||||
}
|
||||
|
||||
|
||||
@@ -88,7 +88,7 @@ function QuestieOptionsDefaults:Load()
|
||||
enableTooltipsQuestID = false,
|
||||
enableTooltipsQuestLevel = true,
|
||||
enableTooltipsSource = false,
|
||||
elvuiStyleTooltips = true,
|
||||
elvuiStyleTooltips = false,
|
||||
showQuestXpAtMaxLevel = true,
|
||||
enableTooltipsNextInChain = true,
|
||||
learnerTooltips = true,
|
||||
|
||||
Reference in New Issue
Block a user