From f9a3301584602f6c8df974260dea9699bd71fbdc Mon Sep 17 00:00:00 2001 From: Xurkon Date: Mon, 8 Jun 2026 21:40:10 -0500 Subject: [PATCH] fix(tooltip): remove misleading data-source attribution line MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The Source: line cannot accurately reflect per-pin provenance without changing every spawn registration site. Until that infrastructure exists, the label is misleading — showing Questie DB even when data came from the learner, or Learner when it came from AscensionDB. Remove from both MapIconTooltip (world-map pins) and Tooltip (unit/object hover). --- Modules/Tooltips/MapIconTooltip.lua | 6 +---- Modules/Tooltips/Tooltip.lua | 37 ++--------------------------- 2 files changed, 3 insertions(+), 40 deletions(-) diff --git a/Modules/Tooltips/MapIconTooltip.lua b/Modules/Tooltips/MapIconTooltip.lua index 364a083..31420c3 100644 --- a/Modules/Tooltips/MapIconTooltip.lua +++ b/Modules/Tooltips/MapIconTooltip.lua @@ -70,11 +70,7 @@ local DEFAULT_WAYPOINT_HOVER_COLOR = { 0.93, 0.46, 0.13, 0.8 } local lastTooltipShowTimestamp = GetTime() local function _GetWorldMapTooltipSourceLine() - local parts = { "Questie DB" } - if QuestieComms and (QuestieComms.remotePlayerEnabled or QuestieComms.data) then - tinsert(parts, "Comms") - end - return "|cFF808080Source: " .. table.concat(parts, " + ") .. "|r" + return nil end function MapIconTooltip:Show() diff --git a/Modules/Tooltips/Tooltip.lua b/Modules/Tooltips/Tooltip.lua index 5f35242..58e5387 100644 --- a/Modules/Tooltips/Tooltip.lua +++ b/Modules/Tooltips/Tooltip.lua @@ -116,44 +116,11 @@ local function _GetQuestObjectiveSummary(questId) end local function _BuildTooltipSourceLine(sourceFlags) - if not sourceFlags then - return nil - end - - local parts = {} - if sourceFlags.static then - tinsert(parts, "Static DB") - end - if sourceFlags.learner then - tinsert(parts, "Learner") - end - if sourceFlags.comms then - tinsert(parts, "Comms") - end - - if table.getn(parts) == 0 then - return nil - end - - return "|cFF808080Source: " .. table.concat(parts, " + ") .. "|r" + return nil end local function _GetTooltipSourceLine(key) - local sourceFlags = {} - - local QuestieLearner = QuestieLoader:ImportModule("QuestieLearner") - local mode = QuestieLearner and QuestieLearner.GetDataSourceMode and QuestieLearner:GetDataSourceMode() or "auto" - if mode == "learner" then - sourceFlags.learner = true - else - sourceFlags.static = true - end - - if QuestieComms and QuestieComms.data and QuestieComms.data.KeyExists and QuestieComms.data:KeyExists(key) then - sourceFlags.comms = true - end - - return _BuildTooltipSourceLine(sourceFlags) + return nil end ---@param questId number