Compare commits

...

7 Commits

Author SHA1 Message Date
Narcasung e66a7a6354 Always skin the options the CoA client adds
That pass only fills the gaps ElvUI's own Blizzard options skin leaves,
so a switch of its own was never a meaningful choice: it follows
E.private.skins.blizzard.enable, the same gate ElvUI checks.
2026-08-22 16:59:59 +02:00
Narcasung 63e179e96e Keep the scroll arrows skinned when the list refreshes
The scroll frame re-shows the button's own native art whenever it
recalculates, and one skinning pass can't hold against it: ElvUI's
HandleNextPrevButton guards on isSkinned, so a second call does nothing.

The talent frame already carried the answer -- re-hide the art by file
from OnUpdate and pin the three state textures -- so it moves into the
shared layer as Skin:ScrollArrow and the Challenges list scrolls take it
too. Routing the talent frame through it also picks up the
disabled-hover fix every other button already has.
2026-08-22 16:59:59 +02:00
Narcasung 013fe665ab Skin the Challenges frame's Gamemodes tab
The Trials shape a third time, and again suffix for suffix: the search
box and list container are named off the tab exactly as Trials names
its own, the list's only region is the same store divider, and the
scroll arrows hang off the scroll frame rather than off the bar. So the
divider constant is shared rather than copied and the three calls go in
unchanged.

The one difference is the filter, which this tab does not have. Its two
children are the search box and the list and neither is a menu, so
there is nothing for a Dropdown call to be handed. That is written into
the comment rather than left implicit: with the same function sitting
three times over in the file, a missing fourth line otherwise reads as
an oversight.

The tab owns no regions of its own at all, so nothing here needs the
keepTextures care the Rewards tab's PageText took. Both children exist
on a cold reload, before the tab has ever been opened, and the counts
are unchanged after a click, so it rides SkinContents with the rest
rather than needing a hook on its own OnShow.

Everything reuses an existing helper, so the shared layer is unchanged.
2026-08-22 16:50:05 +02:00
Narcasung d9476af220 Skin the Challenges frame's Challenges tab
The tab is the Trials tab again in every detail that matters: the same
three children under the same suffixes, the same store divider as its
list container's only region, the same silver-button filter, and its
scroll arrows named off the scroll frame rather than off the bar. So it
takes the same four calls, sharing the divider constant rather than
copying it.

Everything exists before the tab has ever been opened, so it goes
through SkinContents with the rest and needs no hook of its own.
2026-08-22 16:47:04 +02:00
Narcasung cafc3ce28f Skin the Challenges frame's Rewards tab
The tab's twenty-nine children all exist on a cold reload, before it has
ever been opened, so this goes through SkinContents with the rest of the
window rather than needing a hook on the tab's own OnShow -- which a tab
switch would have wanted, since switching tabs fires nothing.

None of the Trials tab's naming carries over. Its search box is
TrialsTabSearch and its filter a FilterDropDown, where these are
StoreTabSearchBox and Filter, so every suffix was confirmed rather than
copied and the divergence is written down for the four tabs still to do.

The Filter is the one widget that had to be read twice. Structurally it
is a plain Button -- no Middle texture, no Button child, no Text
fontstring -- so the test the Interface Options sweep settled on says it
is not a dropdown. By art it plainly is: the same nine Silver-Button
slices and ChatFrameExpandArrow caret the Trials filter wears. Dropdown
matches on the art rather than on the naming, so it takes it unchanged;
the structural test is only ever a shortcut to that question and here it
answers it wrongly.

The grid is a fixed pool of twenty-one cards built up front, not one
built per page, so a single pass covers every card the tab will ever
show and nothing hangs off a page-change hook. The icon crop is the
exception and is re-applied from a hook on the texture's SetTexture: the
store refills the pool in place on every search, filter and page change,
and SetTexture resets a texture's coords, so a one-shot crop survives
exactly until the first page turn and then the native icon borders come
back on every card at once. The slot plate underneath needs no such
watch -- StripArtByFile noops its SetTexture, so a refill that re-arts it
writes nothing.

Cards take HandleButton's useCreateBackdrop path rather than its default
SetTemplate one, which is what makes their padding possible: a template
is drawn as regions of the button and can only ever match its rect, and
the rect is tight -- 140x32 around a 32px icon, so the icon met the top
and bottom edges and the name ran to the right one. A backdrop is a
child frame that can be set outside it. Same reasoning as the window
panel's, one level down. The hover colouring follows either way, since
it resolves button.backdrop before the button itself.

The two headings above the grid are Buttons by type but captions by
function, so their atlas art comes off and nothing goes back: a backdrop
would draw a box around a caption, and the HIGHLIGHT layer would light
it up under a cursor with nothing behind it. They are walked off the
layout rather than named, the set being one per reward vendor.

Left alone deliberately: the Currency button, which carries the trophy
icon and its counter as its only two regions and no frame art at all,
and PageText, which is a region of the tab itself -- the same trap as
the vanity store's counters. Nothing here blind-strips the tab. No
scroll bar is wired either; the grid pages rather than scrolls and has
no scroll frame to hang one off.

Everything reuses an existing helper, so the shared layer is unchanged.
2026-08-22 16:43:00 +02:00
Narcasung a8541fa1ee Skin the Challenges window, its tab row and the Trials tab
ChallengesFrame is a HIGH-strata window parented straight to UIParent and
mouse-enabled itself, not one of the three that hang off the Collections
container -- so it gets its own module and its own enable switch rather
than joining the collections group, and it deliberately skips
ApplyWindowScale and CollectionTabs: the first scales Collections, which
would resize the other three windows and not this one, and the second
skins the tab row those three share.

The panel is built as a backdrop instead of through SetTemplate. A
template's backdrop is drawn as regions of the frame and can only match
its rect, and the title sits above that rect -- the native art carries a
banner up there -- so a panel sized to the frame left the title floating
over the open world. A backdrop has points of its own, so its top edge is
pushed up over the title, measured live rather than hardcoded, with the
hit rect and the close button following it. The nine-slice is stripped
rather than run through HideArt for a related reason: the title is one of
its regions, and Hide() would take it down with the border.

The tab row is the first stock Blizzard flavour the plugin skins, so the
shared layer grows to cover it. TAB_TEXTURES picks up the Middle pieces
those name their body after, and the OnUpdate art re-check watches the
Disabled set as well -- that pair is how a stock tab draws its selected
state, so watching only the inactive half missed art returning on
whichever tab was open. Native panel tabs also interlock, each anchored
16px back into the one before it so the ornate end caps overlap, which
reads as one merged bar once the art is gone; the overlap is absorbed by
narrowing each tab rather than by spacing the row out, which would have
grown it 80px past a frame with 16px of slack. The row is pulled up flush
against the panel it belongs to, since the native tops that spanned that
gap went with the art.

Inside the Trials tab: the search box, the filter dropdown and the scroll
bar. The dropdown is the same widget as the vanity and wardrobe ones and
takes the existing handler unchanged. The search box needs its border
cleared by file, not stripped -- an EditBox draws its caret and selection
highlight as plain textures of its own, and a blind strip leaves a box
you can type in with no cursor in it.

The scroll bar needed a handler of its own. HandleScrollBar reaches for
the thumb through GetThumbTexture and then calls SetTexture on it, but
these bars are hand-built: the thumb is a Button with art of its own, and
the arrows are named off the scroll frame rather than off the bar, so it
finds neither. Both pieces are also arted lazily -- at skin time their
textures read back nil, which is why clearing them, noop'ing their
SetTexture and alpha'ing them all failed in turn -- so the art is
suppressed from OnUpdate, the same answer the tab art needed. Colours
follow ElvUI's own proportional scroll bars, and the track is left empty
rather than given a backdrop.
2026-08-22 16:32:37 +02:00
Narcasung 1a62b4ed1f Skin the options the CoA client adds to Interface, Video and Audio
ElvUI skins the stock options windows from four hardcoded name lists, so
every widget the client added since upstream last synced stays native --
53 of them here, 39 in four panels upstream never enumerated at all
(Battlenet, RaidEffects, Stereo, Voice). Reported cases were the Auto
Accept Trades checkbox and the Spell Queue Window slider.

Sweep the three panel containers on show and skin by object type instead
of carrying a parallel name list that would go stale the same way.

Panels belonging to other addons are skipped by matching frames against
INTERFACEOPTIONS_ADDONCATEGORIES, rebuilt on every sweep so a
load-on-demand addon that registers late is still caught.

Two guards worth naming. Sliders are gated on frame.template because
HandleSliderFrame has no idempotence check of its own and HookScript
stacks, so a second pass over one ElvUI already skinned would run its
OnDisable/OnEnable handlers twice. Dropdowns are detected structurally,
by a Middle texture plus a Button, because HandleDropDownBox uses that
button unguarded and a false positive is a Lua error rather than a
cosmetic miss.

No Button branch: nothing needs one, and it would flatten other addons'
panel tabs into ElvUI pill buttons.
2026-08-22 15:57:21 +02:00
7 changed files with 942 additions and 77 deletions
+2
View File
@@ -18,3 +18,5 @@ Modules\Skinning.lua
Modules\TalentFrame.lua Modules\TalentFrame.lua
Modules\VanityFrame.lua Modules\VanityFrame.lua
Modules\WardrobeFrame.lua Modules\WardrobeFrame.lua
Modules\ChallengesFrame.lua
Modules\InterfaceOptions.lua
+437
View File
@@ -0,0 +1,437 @@
local E, L, V, P, G = unpack(ElvUI)
local CoA = E:GetModule("CoA")
local Skin = CoA.Skin
local FRAME_NAME = "ChallengesFrame"
-- Unlike the talent/vanity/wardrobe trio, this window is not one of the
-- Collections container's children: it's a HIGH-strata frame parented straight
-- to UIParent, and it's mouse-enabled itself rather than being dragged by a
-- container (probed). So it deliberately doesn't go through
-- Skin:ApplyWindowScale or Skin:CollectionTabs -- the first scales Collections,
-- which would resize the other three windows and not this one, and the second
-- skins the tab row those three share, which this window has no part in. A
-- scale slider for it later would set the scale on the frame itself, and the
-- drag target moves with it because the frame is its own drag target.
-- Stock Blizzard panel tabs, unlike every other tab row the plugin skins: plain
-- Buttons rather than CheckButtons, and their art is named Left/Middle/Right
-- (plus the Disabled set Blizzard swaps in for the selected tab) rather than
-- the server's Left/Center/Right -- both flavours are covered by the shared
-- strip in Skinning.lua. They're real children of the frame, so no level parent
-- is needed: normal parent/child z-order already puts them above its panel.
--
-- Six exist today, two of them gated behind content an account may not have, so
-- the row is walked until the first missing index rather than against a
-- hardcoded count -- same shape as Skin:CollectionTabs.
--
-- This is the one row in the plugin that interlocks: every tab past the first is
-- anchored 16px back into the one before it (probed) so the native end caps
-- overlap, which reads as a single merged bar once the art is gone. Hence the
-- unoverlap flag; the server-authored rows sit apart already and don't take it.
local MAX_TABS = 10
local function SkinTabs()
for i = 1, MAX_TABS do
local tab = _G[FRAME_NAME.."Tab"..i]
if not tab then break end
Skin:Tab(tab, nil, true)
end
end
-- The row hangs 6px clear of the frame's bottom edge (probed), which the native
-- art spanned with the tabs' own ornate tops -- gone with the art, so the row
-- reads as detached from the window it belongs to. Only the first tab carries a
-- vertical offset at all, the rest being anchored off its edge, so moving it
-- moves the row.
--
-- Set to the backdrop inset rather than to zero: the tab's flat backdrop starts
-- that far inside the tab, so a tab flush with the frame still leaves its
-- visible edge floating. Written as an absolute rather than as an adjustment to
-- what's there, which keeps it idempotent across the repeated skin passes.
local function AnchorTabRow()
local tab = _G[FRAME_NAME.."Tab1"]
if not tab then return end
local point, relativeTo, relativePoint, x = tab:GetPoint(1)
if not point then return end
tab:SetPoint(point, relativeTo, relativePoint, x, Skin.TabBackdropInset)
end
-- The nine-slice draws the ornate purple border and the teal inner panel over
-- the top of the frame, doubling up with the Transparent template's own border
-- -- but unlike the talent and wardrobe frames' nine-slices it isn't purely
-- decorative: the window's title is one of its regions (probed: nine BORDER
-- textures, one ARTWORK texture, and the title FontString). So it's stripped
-- rather than run through Skin:HideArt, whose Hide() would take the title down
-- with the border. StripTextures only touches Textures, so the art goes and the
-- FontString stays.
local function StripBorderArt()
local nineSlice = _G[FRAME_NAME.."NineSlice"]
if not nineSlice then return end
nineSlice:StripTextures()
end
-- That title has no name of its own -- there is no ChallengesFrameTitleText,
-- and none of the other usual suffixes resolve either (probed) -- so it's
-- picked out by type, the same way the vanity frame's pager arrows are picked
-- out by position. The nine-slice owns exactly one FontString.
local function GetTitle()
local nineSlice = _G[FRAME_NAME.."NineSlice"]
if not nineSlice then return end
for i = 1, nineSlice:GetNumRegions() do
local region = select(i, nineSlice:GetRegions())
if region:GetObjectType() == "FontString" then return region end
end
end
-- Vertical slack left above the title inside the widened panel.
local TITLE_PADDING = 6
-- The title is drawn above the frame's own top edge -- the native art carries a
-- banner up there that the frame's rect doesn't include -- so a panel sized to
-- the frame leaves the title floating over the open world. The panel is built
-- as a backdrop rather than through SetTemplate for exactly this reason: a
-- template's backdrop is drawn as regions of the frame itself and can only ever
-- match its rect, while a backdrop is a child frame with points of its own, so
-- its top edge can be pushed up to take the title in.
--
-- The distance is measured live rather than hardcoded: it's whatever gap the
-- server's own layout left between the title and the frame, so this stays right
-- if that layout changes. Re-measured on every show for the same reason the tab
-- heights are (see Skinning.lua) -- on a cold /reload the layout isn't settled
-- at skin time, and a one-shot measurement catches a stale value.
--
-- The hit rect is grown to match. The frame is its own drag target (probed), and
-- without this the widened panel would have a band along its top that looks part
-- of the window but can't be grabbed.
local function UpdatePanelTop(frame)
local backdrop = frame.backdrop
local title = GetTitle()
if not (backdrop and title) then return end
local frameTop, titleTop = frame:GetTop(), title:GetTop()
if not (frameTop and titleTop) then return end
local offset = titleTop - frameTop + TITLE_PADDING
if offset < 0 then offset = 0 end
backdrop:Point("TOPLEFT", frame, "TOPLEFT", 0, offset)
backdrop:Point("BOTTOMRIGHT", frame, "BOTTOMRIGHT", 0, 0)
-- Negative insets grow the hit rect outwards rather than shrinking it.
frame:SetHitRectInsets(0, 0, -offset, 0)
end
-- Per-tab contents. Each of the six tabs owns its own copy of these widgets
-- rather than sharing one set, so they're skinned per tab; Trials, Rewards,
-- Challenges and Gamemodes are done, and the two left follow the same shape.
--
-- Nothing about one tab's naming carries to the next: the Trials search box is
-- "...TrialsTabSearch" and its filter a "...FilterDropDown", where the Rewards
-- pair are "...StoreTabSearchBox" and "...Filter" (probed). Every suffix on a
-- new tab is worth confirming rather than copying.
local TRIALS_TAB = FRAME_NAME.."TrialsTab"
local TRIALS_LIST = TRIALS_TAB.."Challenges"
local TRIALS_SCROLL = TRIALS_LIST.."ScrollFrame"
-- The list container's one and only region: a 2px rule drawn across the bottom
-- of the panel from the store art (probed). It's the native panel's own divider,
-- and with the panel around it flat there's nothing left for it to divide.
local LIST_DIVIDER_ART = "perksactivities"
local function SkinTrialsTab()
Skin:SearchBox(_G[TRIALS_TAB.."Search"])
-- Cleared by file rather than stripped: the container is the scroll frame's
-- own parent, so a blind strip is a blunter instrument than one known region
-- needs, and StripArtByFile's noop holds if the list ever re-arts it.
Skin:StripArtByFile(_G[TRIALS_LIST], LIST_DIVIDER_ART)
-- The same nine "UI-Silver-Button" slices and ChatFrameExpandArrow caret as
-- the vanity and wardrobe dropdowns (probed), so it takes the same handler.
-- Nothing is passed for its popout: the Trials tab has exactly three children
-- and none of them is a menu (probed), so wherever the list is built it isn't
-- there. Skin:Dropdown skips that half when it's handed nil.
Skin:Dropdown(_G[TRIALS_TAB.."FilterDropDown"])
-- The arrows are named off the scroll frame rather than off the bar, which is
-- the other reason S:HandleScrollBar can't find them on its own.
Skin:ScrollBar(
_G[TRIALS_SCROLL.."ScrollBar"],
_G[TRIALS_SCROLL.."ScrollBarThumb"],
_G[TRIALS_SCROLL.."ScrollUpButton"],
_G[TRIALS_SCROLL.."ScrollDownButton"]
)
end
local STORE_TAB = FRAME_NAME.."StoreTab"
local STORE_LAYOUT = STORE_TAB.."StoreButtonLayout"
-- Walked to the first missing index rather than against the twenty-one that
-- exist today, the same shape as the tab row: this count is a page size, and a
-- page size is exactly the sort of thing a content patch moves.
local MAX_SLOTS = 40
-- The bevelled empty-slot plate every bag and auction square on this client
-- draws, here behind each reward card (probed). The dashes are escaped because
-- StripArtByFile matches with find, where an unescaped dash is a pattern range.
local SLOT_ART = "UI%-AuctionFrame%-ItemSlot"
-- The card's rect is drawn tight around its contents: 140x32 with a 32px icon,
-- so the icon meets the top and bottom edges exactly and the name runs to the
-- right one. The native plate hid that by bleeding a bevel outwards; a flat
-- backdrop on the same rect just looks cramped. The grid leaves far more room
-- than this between cards -- tens of pixels each way -- so the box is grown
-- rather than the contents moved in, which would fight the store's own layout.
local CARD_PADDING = 4
-- The headings above the grid are drawn out of the quest log's atlas by tex
-- coord (probed: three slices plus the button's own NormalTexture, all one
-- file). Cleared by file rather than stripped so the label survives.
local HEADING_ART = "questmaplogatlas"
-- A row rather than an item square: 140x32 with a 32px icon flush left, then
-- the name, then a SimpleHTML cost (probed). The icon is a region of the button
-- itself rather than sitting in a frame of its own, unlike the talent menu's
-- rows, so it takes the crop but not a backdrop of its own.
--
-- The card takes HandleButton's useCreateBackdrop path rather than its default
-- SetTemplate one, which is what makes the padding possible at all: a template
-- is drawn as regions of the button and can only ever match its rect, while a
-- backdrop is a child frame that can be set outside it. Same reasoning as the
-- window panel's, one level down. Skin:Button's hover colouring follows either
-- way -- it resolves button.backdrop before the button itself.
--
-- The native hover square needs nothing by name: it's a plain region on the
-- HIGHLIGHT layer (probed), which is the whole layer Skin:Button's
-- StripHighlightArt takes.
--
-- The crop is re-applied from a hook rather than set once. The grid is a fixed
-- pool the store refills in place on every search, filter and page change, and
-- SetTexture resets a texture's coords -- so a one-shot crop would survive
-- exactly until the first page turn, and the native icon borders would come
-- back on every card at once. The plate underneath needs no such watch:
-- StripArtByFile noops its SetTexture, so a refill that re-arts it writes
-- nothing.
local function SkinStoreCard(slot)
if not slot then return end
Skin:StripArtByFile(slot, SLOT_ART)
Skin:Button(slot, nil, nil, true)
-- Re-set on every pass rather than once: SetOutside writes fixed points, so
-- a UI scale change that moves what a pixel is leaves them stale.
if slot.backdrop then
slot.backdrop:SetOutside(slot, CARD_PADDING, CARD_PADDING)
end
local name = slot:GetName()
local icon = name and _G[name.."Icon"]
if not icon then return end
icon:SetTexCoord(unpack(E.TexCoords))
-- Guarded separately from Skin:Button's own flag, and for the same reason it
-- guards its own: this runs again on every show, and hooksecurefunc stacks
-- handlers rather than replacing them.
if not slot.CoAIconHooked then
slot.CoAIconHooked = true
hooksecurefunc(icon, "SetTexture", function(texture)
texture:SetTexCoord(unpack(E.TexCoords))
end)
end
end
-- "Trial Master's Rewards" and its sibling for the build vendor are Buttons by
-- type, but they aren't buttons: they're the grid's section headings, drawn as
-- a stylised plaque and doing nothing when clicked. So they get their art taken
-- off and nothing put back -- no backdrop, which would draw a box around a
-- caption and read as clickable, and no hover border for the same reason. The
-- HIGHLIGHT layer goes too, or the caption lights up under the cursor with
-- nothing behind it.
--
-- Walked off the layout rather than named, since the set is one per reward
-- vendor and grows with content. Same reasoning as the tab row.
local function SkinStoreHeadings()
local layout = _G[STORE_LAYOUT]
if not layout then return end
for i = 1, layout:GetNumChildren() do
local heading = select(i, layout:GetChildren())
Skin:StripArtByFile(heading, HEADING_ART)
Skin:StripHighlightArt(heading)
end
end
-- Everything on this tab exists before it has ever been opened (probed: the
-- same twenty-nine children on a cold reload as after a click), so it goes
-- through SkinContents with the rest rather than needing a hook on the tab's
-- own OnShow.
--
-- Two things here are deliberately left alone. The Currency button carries the
-- trophy icon and the "Trial Master's Trophy: 0" counter as its only two
-- regions and no frame art at all, so there's nothing to strip and a backdrop
-- would only make a label look clickable. PageText is a FontString region of
-- the tab itself -- the same trap as the vanity store's counters, and the
-- reason Skin:Panel grew keepTextures -- so nothing here blind-strips the tab.
--
-- No scroll bar is wired: the grid pages rather than scrolls, and there's no
-- scroll frame anywhere under the tab to hang one off (probed).
local function SkinStoreTab()
Skin:SearchBox(_G[STORE_TAB.."SearchBox"])
-- Not a dropdown by structure -- no Middle texture, no Button child, no Text
-- fontstring, just a plain Button (probed) -- but it is one by art: the same
-- nine "UI-Silver-Button" slices and ChatFrameExpandArrow caret the Trials
-- filter wears. Skin:Dropdown matches on the art rather than on the naming,
-- so it takes this one too; the Middle-plus-Button structural test is only
-- ever a shortcut to that question, and here it answers it wrongly.
Skin:Dropdown(_G[STORE_TAB.."Filter"])
-- Stock "UI-SquareButton" arrows (probed), unlike the hand-built bar on the
-- Trials list, so these go through the ElvUI handler unaided.
Skin:NextPrevButton(_G[STORE_TAB.."PreviousPageButton"], "left")
Skin:NextPrevButton(_G[STORE_TAB.."NextPageButton"], "right")
SkinStoreHeadings()
for i = 1, MAX_SLOTS do
local slot = _G[STORE_TAB.."Slot"..i]
if not slot then break end
SkinStoreCard(slot)
end
end
local CHALLENGES_TAB = FRAME_NAME.."ChallengesTab"
local CHALLENGES_LIST = CHALLENGES_TAB.."Challenges"
local CHALLENGES_SCROLL = CHALLENGES_LIST.."ScrollFrame"
-- The one tab whose naming does carry over from another: the same three
-- children as Trials, under the same suffixes, with the same store divider as
-- its list container's only region, the same nine "UI-Silver-Button" slices and
-- caret on its filter, and its arrows named off the scroll frame rather than
-- off the bar (probed). So it takes the Trials treatment call for call -- see
-- SkinTrialsTab above for why each of the four is the call it is.
--
-- The divider constant is shared rather than copied: it is the same 2px rule out
-- of the same file, not a second one that happens to match today.
local function SkinChallengesTab()
Skin:SearchBox(_G[CHALLENGES_TAB.."Search"])
Skin:StripArtByFile(_G[CHALLENGES_LIST], LIST_DIVIDER_ART)
Skin:Dropdown(_G[CHALLENGES_TAB.."FilterDropDown"])
Skin:ScrollBar(
_G[CHALLENGES_SCROLL.."ScrollBar"],
_G[CHALLENGES_SCROLL.."ScrollBarThumb"],
_G[CHALLENGES_SCROLL.."ScrollUpButton"],
_G[CHALLENGES_SCROLL.."ScrollDownButton"]
)
end
local GAMEMODES_TAB = FRAME_NAME.."GamemodesTab"
local GAMEMODES_LIST = GAMEMODES_TAB.."Challenges"
local GAMEMODES_SCROLL = GAMEMODES_LIST.."ScrollFrame"
-- The Trials/Challenges shape a third time, and again suffix for suffix: the
-- same search box and list names, the same store divider as its list
-- container's only region, the same arrows named off the scroll frame rather
-- than off the bar (probed). See SkinTrialsTab above for why each call is the
-- call it is.
--
-- What differs is the filter: there isn't one, and that's the tab's own shape
-- rather than something missed here. It has exactly two children, the search
-- box and the list, and neither of them is a menu (probed), so there is nothing
-- for a Skin:Dropdown line to be handed.
--
-- It owns no regions of its own either (probed), so nothing here needs the
-- keepTextures care the Rewards tab's PageText took. And everything under it
-- exists before the tab has ever been opened -- two children and no regions on
-- a cold reload, unchanged after a click -- so it rides SkinContents like the
-- other three rather than needing a hook on the tab's own OnShow.
local function SkinGamemodesTab()
Skin:SearchBox(_G[GAMEMODES_TAB.."Search"])
Skin:StripArtByFile(_G[GAMEMODES_LIST], LIST_DIVIDER_ART)
Skin:ScrollBar(
_G[GAMEMODES_SCROLL.."ScrollBar"],
_G[GAMEMODES_SCROLL.."ScrollBarThumb"],
_G[GAMEMODES_SCROLL.."ScrollUpButton"],
_G[GAMEMODES_SCROLL.."ScrollDownButton"]
)
end
-- The close button is anchored inside the frame's own top-right corner, which
-- stopped being the corner the player sees once the panel grew up over the title
-- band -- it ends up floating a title's height below the top edge. Re-anchored
-- to the panel instead, and re-run on every pass so it follows the panel's top
-- whenever that gets re-measured.
--
-- No offset of its own: Skin:CloseButton normalises the button to a 32px box
-- with a 12px X centred in it, so the margin off the corner is already built in.
local function AnchorCloseButton(frame)
local close = _G[FRAME_NAME.."CloseButton"]
if not (close and frame.backdrop) then return end
close:ClearAllPoints()
close:SetPoint("TOPRIGHT", frame.backdrop, "TOPRIGHT", 0, 0)
end
-- Nothing here re-runs on a tab switch, and nothing needs to: switching tabs
-- doesn't fire the frame's OnShow, and the one thing a switch does disturb is
-- the tab art, which Skin:Tab watches from its own OnUpdate. The title
-- fontstring is reused across tabs rather than swapped for a per-tab one -- its
-- text changes, the object doesn't -- so it only needs the one pass too.
local function SkinContents()
StripBorderArt()
Skin:Title(GetTitle())
UpdatePanelTop(_G[FRAME_NAME])
Skin:CloseButton(_G[FRAME_NAME.."CloseButton"])
AnchorCloseButton(_G[FRAME_NAME])
SkinTabs()
AnchorTabRow()
SkinTrialsTab()
SkinStoreTab()
SkinGamemodesTab()
SkinChallengesTab()
end
local function SkinFrame(frame)
if not frame.CoASkinned then
frame.CoASkinned = true
-- A single BACKGROUND texture is all the frame owns (probed), and it's
-- decorative -- nothing functional is drawn as a region of this frame,
-- unlike the vanity store, whose currency counters are. So it's stripped
-- outright. Stripped before the backdrop is made, not after: a backdrop
-- built first would be a child frame and survive, but the order is kept
-- the same as Skin:Panel's for one less rule to remember.
frame:StripTextures()
frame:CreateBackdrop("Transparent")
frame:HookScript("OnShow", SkinContents)
end
SkinContents()
end
local function TryHook()
local frame = _G[FRAME_NAME]
if not frame then return false end
SkinFrame(frame)
return true
end
function CoA:InitializeChallengesFrame()
if not E.private.skins.blizzard.enable then return end
Skin:OnFrameAvailable(TryHook)
end
+142
View File
@@ -0,0 +1,142 @@
local E, L, V, P, G = unpack(ElvUI)
local S = E:GetModule("Skins")
local CoA = E:GetModule("CoA")
local _G = _G
local ipairs, pairs, select, type = ipairs, pairs, select, type
-- Generic sweep over the stock options windows.
--
-- ElvUI skins those windows from four hardcoded name lists (checkboxes,
-- sliders, buttons, dropdowns) in Modules/Skins/Blizzard/BlizzardOptions.lua,
-- so anything the client added since upstream last synced stays native --
-- 53 widgets on this server, 39 of them in four panels upstream never
-- enumerated at all (Battlenet, RaidEffects, Stereo, Voice). Rather than
-- carry a parallel name list that goes stale the same way, this walks the
-- panel containers and skins by object type.
local MAX_DEPTH = 3
-- Every panel is parented at load (probed: the Interface container reports the
-- same child count before and after opening the window), so the containers can
-- be walked without waiting for a category to be displayed.
local ROOTS = {
"InterfaceOptionsFramePanelContainer",
"VideoOptionsFramePanelContainer",
"AudioOptionsFramePanelContainer",
}
-- Hooked on all three windows rather than only the Interface one: the Video and
-- Audio windows are separate frames reachable straight from the game menu, and
-- a player who opens one of those first would otherwise see it unskinned. Each
-- show sweeps every root, which costs nothing -- the pass is idempotent.
local TRIGGERS = {
"InterfaceOptionsFrame",
"VideoOptionsFrame",
"AudioOptionsFrame",
}
-- Panels owned by other addons, keyed by frame. Rebuilt on every sweep rather
-- than cached at init: load-on-demand addons register their category late, and
-- a set built once would let their panels through on later shows.
local addonPanels = {}
local function RebuildAddOnPanels()
for panel in pairs(addonPanels) do
addonPanels[panel] = nil
end
local categories = _G.INTERFACEOPTIONS_ADDONCATEGORIES
if type(categories) ~= "table" then return end
-- The entries are the panel frames themselves, not descriptors (probed).
-- Matching on the frame is why this doesn't need a name prefix whitelist:
-- an addon can name its panel anything, and the registry is authoritative.
for _, panel in ipairs(categories) do
if type(panel) == "table" then
addonPanels[panel] = true
end
end
end
-- Structural test, not a name test. S:HandleDropDownBox uses _G[name.."Button"]
-- unguarded when anchoring its backdrop, so a false positive is a Lua error
-- rather than a cosmetic miss; it also force-sets the frame's width, which
-- mangles a group box even when it doesn't error. A DropDown name suffix was
-- considered and rejected -- ElvUI's own dropdown list carries
-- CompactUnitFrameProfilesProfileSelector (no suffix) and ...SortByDropdown
-- (lowercase d), so suffix matching misses real dropdowns and adds nothing.
local function IsDropDown(frame)
local name = frame.GetName and frame:GetName()
if not name then return false end
local middle = _G[name.."Middle"]
if not middle or not middle.IsObjectType or not middle:IsObjectType("Texture") then return false end
return _G[name.."Button"] ~= nil
end
-- depth is the depth of the children being visited, counting the container's
-- own children as 1. Three is enough for the deepest real case: the Controls
-- panel's anonymous "Looting Options" group box and the compact raid frame
-- profile dialogs both hold their widgets a level below the panel.
local function Sweep(frame, depth)
for i = 1, frame:GetNumChildren() do
local child = select(i, frame:GetChildren())
if child and not addonPanels[child] then
local objectType = child:GetObjectType()
if objectType == "CheckButton" then
S:HandleCheckBox(child)
elseif objectType == "Slider" then
-- The gate is load-bearing, not an optimisation:
-- HandleSliderFrame has no idempotence guard of its own and
-- HookScript stacks, so a second pass over a slider ElvUI
-- already skinned would run its OnDisable/OnEnable handlers
-- twice. E:SetTemplate sets frame.template, so that field is
-- the "already skinned" marker for sliders.
if not child.template then
S:HandleSliderFrame(child)
end
elseif objectType == "Frame" and IsDropDown(child) then
S:HandleDropDownBox(child)
elseif depth < MAX_DEPTH then
-- Deliberately no Button branch: nothing in the sweep needs one,
-- and it would flatten other addons' panel tabs -- object type
-- Button, but tabs -- into ElvUI pill buttons.
Sweep(child, depth + 1)
end
end
end
end
local function SweepOptions()
RebuildAddOnPanels()
for _, name in ipairs(ROOTS) do
local root = _G[name]
if root then
Sweep(root, 1)
end
end
end
function CoA:InitializeInterfaceOptions()
-- The same two switches that gate ElvUI's own pass: if the user turned the
-- stock options skin off, the gap this fills isn't a gap any more.
if not E.private.skins.blizzard.enable then return end
if not E.private.skins.blizzard.BlizzardOptions then return end
-- Skinning on show rather than at init puts the sweep after ElvUI's
-- Skin_BlizzardOptions callback with no ordering work, and re-running it on
-- every show catches panels that only appear once their addon loads.
for _, name in ipairs(TRIGGERS) do
local frame = _G[name]
if frame then
frame:HookScript("OnShow", SweepOptions)
end
end
end
+315 -14
View File
@@ -210,6 +210,23 @@ function Skin:Button(button, ...)
end end
end end
-- S:HandleNextPrevButton routes through S:HandleButton, so it inherits exactly
-- the lit-border-on-a-dead-button behaviour OnButtonEnter is here to correct,
-- and scroll arrows spend a good deal of their life disabled at one end of their
-- list or the other. Same separate guard as Skin:Button, and for the same
-- reason: these frames re-run their skin passes, and HookScript stacks.
function Skin:NextPrevButton(button, direction)
if not button then return end
S:HandleNextPrevButton(button, direction)
if not button.CoAButtonSkinned then
button.CoAButtonSkinned = true
button:HookScript("OnEnter", OnButtonEnter)
end
end
-- Several of these controls draw their art as anonymous regions of one atlas -- Several of these controls draw their art as anonymous regions of one atlas
-- file rather than through the named Left/Middle/Right fields or the Normal/ -- file rather than through the named Left/Middle/Right fields or the Normal/
-- Pushed/Disabled set S:HandleButton knows how to clear, so its own clearing -- Pushed/Disabled set S:HandleButton knows how to clear, so its own clearing
@@ -316,16 +333,235 @@ function Skin:Dropdown(dropdown, menu)
self:Panel(menu) self:Panel(menu)
end end
-- The CoA search boxes draw their border and magnifier from the stock
-- "CommonSearch" file, tinted to the server's own colour, as anonymous regions
-- -- so S:HandleEditBox can't reach them: it only alpha-0s the named Left/
-- Middle/Right pieces a stock Blizzard edit box has.
--
-- Cleared by file rather than by a blind strip, which is what a first pass did:
-- an EditBox draws its own caret and its selection highlight as plain solid
-- textures of its own (probed: four of them, sub-pixel wide and text-high, shown
-- only while the box has focus), and StripTextures takes those with the border,
-- leaving a search box you can type in with no cursor in it.
local SEARCH_BOX_ART = "CommonSearch"
function Skin:SearchBox(box)
if not box or box.CoASearchSkinned then return end
box.CoASearchSkinned = true
self:StripArtByFile(box, SEARCH_BOX_ART)
S:HandleEditBox(box)
end
-- Scroll bars ------------------------------------------------------------------
--
-- S:HandleScrollBar can't be used on these: the CoA bars are hand-built rather
-- than the stock Slider widget, so the thumb is a Button with art of its own
-- (probed) where a stock bar has a thumb *texture*, and HandleScrollBar reaches
-- for the thumb through GetThumbTexture and then calls SetTexture on what it
-- finds. It also looks the arrow buttons up as children of the bar, and these
-- are named off the scroll frame instead. The treatment below is the same one it
-- applies, only with each piece handed in by the caller.
--
-- The art on both pieces is applied lazily, and that is what defeated two
-- earlier passes at this: at skin time the thumb's textures read back nil, so
-- matching them by file found nothing to clear, and the scroll code arts them a
-- moment later when it first measures the list. Clearing, noop'ing the regions'
-- SetTexture, and alpha'ing them all failed the same way -- not because the art
-- came back, but because it was never there yet to be taken.
--
-- So it's handled from OnUpdate, the same answer the tab art needed and for the
-- same reason: nothing fires when it happens, and the check is a three-region
-- alpha compare that only writes when something has actually re-arted the
-- widget. Blanket rather than matched by file: neither the track nor the thumb
-- carries anything but its own art -- no label, no counter -- which is the only
-- thing StripArtByFile's file matching is there to protect.
local function HideScrollArt(frame)
for i = 1, frame:GetNumRegions() do
local region = select(i, frame:GetRegions())
if region:GetObjectType() == "Texture" and region:GetAlpha() ~= 0 then
region:SetAlpha(0)
end
end
end
-- Colours and states taken from ElvUI's own proportional scroll bars
-- (S:HandleProportionalScroll), which is what every other scroll bar in this UI
-- looks like: the value colour at a quarter alpha, three quarters while hovered
-- or held. Its handlers are locals in ElvUI's file, so the four scripts are
-- written out here rather than reached for.
--
-- The active flag is what keeps a thumb lit while it's being dragged: the
-- pointer routinely leaves a thin thumb mid-drag, and OnLeave would otherwise
-- dim it while the list is still moving under it.
local SCROLL_BUTTON_GAP = 1
local SCROLL_THUMB_ALPHA = 0.25
local SCROLL_THUMB_ACTIVE_ALPHA = 0.75
local function SetThumbColor(thumb, alpha)
if not thumb.backdrop then return end
local r, g, b = unpack(E.media.rgbvaluecolor)
thumb.backdrop:SetBackdropColor(r, g, b, alpha)
end
local function ThumbOnEnter(thumb)
SetThumbColor(thumb, SCROLL_THUMB_ACTIVE_ALPHA)
end
local function ThumbOnLeave(thumb)
if thumb.CoAThumbActive then return end
SetThumbColor(thumb, SCROLL_THUMB_ALPHA)
end
local function ThumbOnMouseDown(thumb)
thumb.CoAThumbActive = true
SetThumbColor(thumb, SCROLL_THUMB_ACTIVE_ALPHA)
end
local function ThumbOnMouseUp(thumb)
thumb.CoAThumbActive = nil
SetThumbColor(thumb, SCROLL_THUMB_ALPHA)
end
-- The arrows re-art themselves the same way the track and thumb do, and one
-- pass can't hold against it: S:HandleNextPrevButton guards on its own
-- isSkinned flag, so calling it a second time does nothing at all. What comes
-- back isn't the ElvUI arrow being overwritten either -- that texture is still
-- in place underneath (probed: the native "scrollbarproportional" region shown
-- alongside ArrowUp). It's the button's own art, which StripTextures only hid,
-- and the scroll frame shows it again whenever it recalculates.
--
-- So the native art is re-hidden by file from OnUpdate, the same answer the
-- track, the thumb and the tab art all needed and for the same reason: nothing
-- fires when it happens. The three state textures are captured and their
-- setters noop'd as well -- still worth closing off, since whatever refreshes
-- these is free to swap in a fresh texture object and orphan the three.
--
-- Matched by file rather than as "any region that isn't one of ours": ElvUI's
-- own panel and border pieces are regions of the button too, so hiding
-- everything unrecognised would take the ElvUI square with it. Compared
-- case-insensitively -- the client hands paths back from GetTexture in whatever
-- case it stored them, not the case they were set in.
local ARROW_TEXTURE = E.Media.Textures.ArrowUp:lower()
local NATIVE_SCROLL_ART = "scrollbar"
local function RestoreArrow(button)
for i = 1, button:GetNumRegions() do
local region = select(i, button:GetRegions())
local texture = region.GetTexture and region:GetTexture()
if texture and tostring(texture):lower():find(NATIVE_SCROLL_ART) and region:IsShown() then
region:Hide()
end
end
for _, texture in ipairs(button.CoAArrowTextures) do
local current = texture:GetTexture()
if not current or tostring(current):lower() ~= ARROW_TEXTURE then
texture:SetTexture(E.Media.Textures.ArrowUp)
texture:SetInside(button)
texture:SetTexCoord(0, 1, 0, 1)
texture:SetRotation(S.ArrowRotation[button.CoAArrowDirection])
end
end
end
function Skin:ScrollArrow(button, direction)
if not button or button.CoAArrowSkinned then return end
button.CoAArrowSkinned = true
self:NextPrevButton(button, direction)
button.CoAArrowDirection = direction
button.CoAArrowTextures = {
button:GetNormalTexture(),
button:GetPushedTexture(),
button:GetDisabledTexture(),
}
button.SetNormalTexture = E.noop
button.SetPushedTexture = E.noop
button.SetDisabledTexture = E.noop
button.SetHighlightTexture = E.noop
button:HookScript("OnUpdate", RestoreArrow)
end
function Skin:ScrollBar(bar, thumb, up, down)
if not bar or bar.CoASkinned then return end
bar.CoASkinned = true
-- The track gets no backdrop of its own, only its art taken off, which is
-- what ElvUI's own proportional scroll bars do: against these panels an empty
-- channel reads cleaner than a second filled block behind the thumb, and the
-- thumb is legible on its own at the value colour.
bar:HookScript("OnUpdate", HideScrollArt)
if thumb then
thumb:HookScript("OnUpdate", HideScrollArt)
-- Filling the thumb rather than inset inside it: the thumb is already
-- narrower than the track it runs in, so an inset backdrop reads as a thin
-- line rather than as a grip. The track's own gutter is the separation.
--
-- Levelled off the thumb rather than off the track: the thumb sits a level
-- above the track already, so a backdrop built at the track's level would
-- land underneath the thumb's own regions.
thumb:CreateBackdrop("Transparent")
thumb.backdrop:SetFrameLevel(thumb:GetFrameLevel() + 1)
thumb.backdrop:SetAllPoints()
SetThumbColor(thumb, SCROLL_THUMB_ALPHA)
thumb:HookScript("OnEnter", ThumbOnEnter)
thumb:HookScript("OnLeave", ThumbOnLeave)
thumb:HookScript("OnMouseDown", ThumbOnMouseDown)
thumb:HookScript("OnMouseUp", ThumbOnMouseUp)
end
-- Re-anchored onto the track's ends after skinning, and cleared first rather
-- than pointed on top of what's there: HandleNextPrevButton resizes them to
-- ElvUI's own 18px, so whatever the native layout anchored them by no longer
-- lines up with the track, and a second point left in place would stretch the
-- button between the two.
if up then
self:ScrollArrow(up, "up")
up:ClearAllPoints()
up:Point("BOTTOM", bar, "TOP", 0, SCROLL_BUTTON_GAP)
end
if down then
self:ScrollArrow(down, "down")
down:ClearAllPoints()
down:Point("TOP", bar, "BOTTOM", 0, -SCROLL_BUTTON_GAP)
end
end
-- Tabs ----------------------------------------------------------------------- -- Tabs -----------------------------------------------------------------------
-- --
-- S:HandleTab can't be used on any of these: it clears the tab body by name, -- S:HandleTab still isn't used on any of these. On the server-authored tabs it
-- looking for a "Middle" piece, and every CoA tab names theirs "Center", so the -- can't be: it clears the tab body by name, looking for a "Middle" piece, and
-- body survives and the ElvUI backdrop just lands behind the old art. -- those name theirs "Center", so the body survives and the ElvUI backdrop just
-- lands behind the old art. The Challenges window's tabs are stock Blizzard
-- ones that do use "Middle" (probed), so HandleTab would reach them -- they go
-- through the same strip anyway, because one code path is what keeps every tab
-- row in this UI looking alike.
-- --
-- One list covers both tab flavours: the talent frame's tabs carry the -- One list covers all three tab flavours: the talent frame's tabs carry the
-- Disabled variants as well, the wardrobe's category tabs don't, and the -- Disabled variants as well, the wardrobe's category tabs don't, the Challenges
-- lookups for the ones that don't exist simply come back nil. -- tabs use Blizzard's Left/Middle/Right plus the Disabled set Blizzard swaps in
local TAB_TEXTURES = {"Left", "Center", "Right", "LeftDisabled", "CenterDisabled", "RightDisabled"} -- to draw the selected tab, and the lookups for the ones that don't exist
-- simply come back nil.
local TAB_TEXTURES = {
"Left", "Center", "Middle", "Right",
"LeftDisabled", "CenterDisabled", "MiddleDisabled", "RightDisabled",
}
-- Blizzard's own tab code re-sets these textures both when a frame reopens and, -- Blizzard's own tab code re-sets these textures both when a frame reopens and,
-- separately, on every tab switch -- and a switch never fires the owning -- separately, on every tab switch -- and a switch never fires the owning
@@ -348,7 +584,11 @@ function Skin:StripTabArt(tab)
if checked then checked:SetTexture(nil) end if checked then checked:SetTexture(nil) end
end end
-- Exposed: a module that re-anchors a tab row against the frame it belongs to
-- has to know how far inside its tab the backdrop actually starts, or it lines
-- the tab up flush and leaves the visible edge floating by this much.
local TAB_BACKDROP_INSET = 3 local TAB_BACKDROP_INSET = 3
Skin.TabBackdropInset = TAB_BACKDROP_INSET
-- Native tab sizing is a retail leftover -- every other ElvUI tab row in this -- Native tab sizing is a retail leftover -- every other ElvUI tab row in this
-- client reads bigger -- so labelled tabs are grown, off the font's own current -- client reads bigger -- so labelled tabs are grown, off the font's own current
@@ -372,20 +612,59 @@ local TAB_LABEL_OFFSET = 12
-- different float -- so a strict ~= compare never held and this grew every tick -- different float -- so a strict ~= compare never held and this grew every tick
-- without bound. Half a pixel of slack absorbs the rounding while still -- without bound. Half a pixel of slack absorbs the rounding while still
-- catching a genuine Blizzard-driven change, which is always a full tab's worth -- catching a genuine Blizzard-driven change, which is always a full tab's worth
-- of height. -- of height. The same slack covers the width below.
local TAB_HEIGHT_EPSILON = 0.5 local TAB_SIZE_EPSILON = 0.5
local function UpdateTabSize(tab) local function UpdateTabSize(tab)
if not tab.CoAGrowTab then return end if not tab.CoAGrowTab then return end
local height = tab:GetHeight() local height = tab:GetHeight()
if not tab.CoAGrownHeight or math.abs(height - tab.CoAGrownHeight) > TAB_HEIGHT_EPSILON then if not tab.CoAGrownHeight or math.abs(height - tab.CoAGrownHeight) > TAB_SIZE_EPSILON then
tab.CoAGrownHeight = height + TAB_GROWTH tab.CoAGrownHeight = height + TAB_GROWTH
tab:SetHeight(tab.CoAGrownHeight) tab:SetHeight(tab.CoAGrownHeight)
end end
end end
-- Native panel tabs interlock: each is anchored back into the one before it by
-- the width of the art's end cap, so the ornate ends overlap rather than butting
-- together. Strip the art, put a flat backdrop in its place, and that overlap
-- has nothing left to hide it -- the row reads as one merged bar, and the tabs'
-- hit rects overlap along with their backdrops.
--
-- The tab is narrowed by exactly what its anchor was pulled back by, rather than
-- being pushed along to make room: pushing grows the row by the overlap times
-- the number of tabs, which on the Challenges window overhangs the frame by four
-- times the slack the row has. Absorbing it instead leaves the row's total
-- extent exactly where the native layout put it.
--
-- Opt-in per row rather than detected from the anchor: a tab anchored onto its
-- neighbour with a negative offset is the signature of an interlocking row, but
-- it would also match any row that merely sits tight, and silently resizing the
-- server-authored rows on that guess isn't worth the convenience.
local function UnoverlapTab(tab)
local point, relativeTo, relativePoint, x, y = tab:GetPoint(1)
if not (point and x) or x >= 0 then return end
tab.CoATabOverlap = -x
tab:SetPoint(point, relativeTo, relativePoint, 0, y)
end
-- Re-checked every tick with the same self-healing shape as the grown height,
-- and for the same reason: the native tab code re-measures a tab off its own
-- label, and a width written once would be handed straight back.
local function UpdateTabWidth(tab)
local overlap = tab.CoATabOverlap
if not overlap then return end
local width = tab:GetWidth()
if not tab.CoAUnoverlappedWidth or math.abs(width - tab.CoAUnoverlappedWidth) > TAB_SIZE_EPSILON then
tab.CoAUnoverlappedWidth = width - overlap
tab:SetWidth(tab.CoAUnoverlappedWidth)
end
end
-- Tabs that aren't children of the frame they belong to (the talent frame's -- Tabs that aren't children of the frame they belong to (the talent frame's
-- are separately-placed siblings) sit behind its panel art once grown, so they -- are separately-placed siblings) sit behind its panel art once grown, so they
-- get bumped above it. Re-applied every tick rather than on show or on select: -- get bumped above it. Re-applied every tick rather than on show or on select:
@@ -404,15 +683,29 @@ end
-- still comes back, so there's no event to catch it from. Checked from OnUpdate -- still comes back, so there's no event to catch it from. Checked from OnUpdate
-- instead: a cheap GetTexture() compare that only pays for the full strip when -- instead: a cheap GetTexture() compare that only pays for the full strip when
-- the art has actually reappeared. -- the art has actually reappeared.
--
-- Two probes rather than one: a stock Blizzard tab draws its selected state by
-- hiding the Left/Middle/Right set and showing the Disabled set in its place,
-- so watching only the inactive half would miss art returning on whichever tab
-- is currently open. The three pieces of a set are always re-arted together, so
-- one probe per set is enough.
local TAB_ART_PROBES = {"Left", "LeftDisabled"}
local function UpdateTabArt(tab) local function UpdateTabArt(tab)
BumpTabLevel(tab) BumpTabLevel(tab)
UpdateTabSize(tab) UpdateTabSize(tab)
UpdateTabWidth(tab)
local name = tab:GetName() local name = tab:GetName()
local tex = name and _G[name.."Left"] if not name then return end
if tex and tex:GetTexture() then for _, suffix in ipairs(TAB_ART_PROBES) do
Skin:StripTabArt(tab) local tex = _G[name..suffix]
if tex and tex:GetTexture() then
Skin:StripTabArt(tab)
return
end
end end
end end
@@ -443,7 +736,11 @@ end
-- levelParent is the frame the tab must draw above, and is only needed for tabs -- levelParent is the frame the tab must draw above, and is only needed for tabs
-- that aren't its children (see BumpTabLevel). Pass nil for tabs parented to -- that aren't its children (see BumpTabLevel). Pass nil for tabs parented to
-- the frame they belong to -- normal parent/child z-order already covers those. -- the frame they belong to -- normal parent/child z-order already covers those.
function Skin:Tab(tab, levelParent) --
-- unoverlap is for rows of interlocking native tabs (see UnoverlapTab). Only the
-- tabs anchored onto a neighbour take it; the first tab in a row has nothing to
-- pull back from and is left alone by the offset check.
function Skin:Tab(tab, levelParent, unoverlap)
if not tab then return end if not tab then return end
-- Set on every call rather than only the first: the collection tabs are -- Set on every call rather than only the first: the collection tabs are
@@ -457,6 +754,10 @@ function Skin:Tab(tab, levelParent)
self:StripTabArt(tab) self:StripTabArt(tab)
if unoverlap then
UnoverlapTab(tab)
end
-- Default rather than Transparent: tabs sit below their frame over the -- Default rather than Transparent: tabs sit below their frame over the
-- open world, so a see-through panel reads as washed out instead of as -- open world, so a see-through panel reads as washed out instead of as
-- the solid tabs the retail layout has. -- the solid tabs the retail layout has.
+2 -63
View File
@@ -471,67 +471,6 @@ local function SkinScrollThumb(thumb, thumbName)
end) end)
end end
-- The scroll arrows come back as Blizzard chevrons after the list refreshes,
-- and it isn't the ElvUI arrow being overwritten -- that texture is still in
-- place underneath. The button's native art is a region StripTextures hid, and
-- the scroll frame shows it again whenever it recalculates.
--
-- Matched by file rather than as "any region that isn't one of ours": on this
-- client ElvUI's own panel and border pieces are regions of the button too, so
-- hiding everything unrecognised would take the ElvUI square with it.
--
-- Compared case-insensitively: the client hands paths back from GetTexture in
-- whatever case it stored them, not the case they were set in.
local ARROW_TEXTURE = E.Media.Textures.ArrowUp:lower()
local NATIVE_SCROLL_ART = "scrollbar"
local function RestoreArrow(button)
for i = 1, button:GetNumRegions() do
local region = select(i, button:GetRegions())
local texture = region.GetTexture and region:GetTexture()
if texture and texture:lower():find(NATIVE_SCROLL_ART) and region:IsShown() then
region:Hide()
end
end
-- The arrow itself is re-pointed as well, in case a refresh reaches the
-- state textures and not only the art it re-shows.
for _, texture in ipairs(button.CoAArrowTextures) do
local current = texture:GetTexture()
if not current or current:lower() ~= ARROW_TEXTURE then
texture:SetTexture(E.Media.Textures.ArrowUp)
texture:SetInside(button)
texture:SetTexCoord(0, 1, 0, 1)
texture:SetRotation(S.ArrowRotation[button.CoAArrowDirection])
end
end
end
local function SkinArrow(button, direction)
if not button or button.CoASkinned then return end
button.CoASkinned = true
S:HandleNextPrevButton(button, direction)
button.CoAArrowDirection = direction
button.CoAArrowTextures = {
button:GetNormalTexture(),
button:GetPushedTexture(),
button:GetDisabledTexture()
}
-- Still worth closing off: whatever refreshes these would otherwise be free
-- to swap in a fresh texture object and orphan the three above.
button.SetNormalTexture = E.noop
button.SetPushedTexture = E.noop
button.SetDisabledTexture = E.noop
button.SetHighlightTexture = E.noop
button:HookScript("OnUpdate", RestoreArrow)
end
-- The list inside each dropdown popup: a scroll frame with the framed inset -- The list inside each dropdown popup: a scroll frame with the framed inset
-- and overlay art around it. The arrows are named off the scroll frame rather -- and overlay art around it. The arrows are named off the scroll frame rather
-- than off the scrollbar, so they're looked up here instead. -- than off the scrollbar, so they're looked up here instead.
@@ -558,13 +497,13 @@ local function SkinMenuScroll(listName)
local up = _G[listName.."ScrollFrameScrollUpButton"] local up = _G[listName.."ScrollFrameScrollUpButton"]
if up then if up then
up:Point("BOTTOM", scrollBar, "TOP", 0, 1) up:Point("BOTTOM", scrollBar, "TOP", 0, 1)
SkinArrow(up, "up") Skin:ScrollArrow(up, "up")
end end
local down = _G[listName.."ScrollFrameScrollDownButton"] local down = _G[listName.."ScrollFrameScrollDownButton"]
if down then if down then
down:Point("TOP", scrollBar, "BOTTOM", 0, -1) down:Point("TOP", scrollBar, "BOTTOM", 0, -1)
SkinArrow(down, "down") Skin:ScrollArrow(down, "down")
end end
local thumbName = listName.."ScrollFrameScrollBarThumb" local thumbName = listName.."ScrollFrameScrollBarThumb"
+2
View File
@@ -5,9 +5,11 @@ ElvUI plugin that hides and skins the custom CoA (3.3.5) frames not covered by s
## Implemented ## Implemented
- Character advancement, vanity, wardrobe frames: skin, scale - Character advancement, vanity, wardrobe frames: skin, scale
- Challenges frame: skin
- Class resource frames: hiding - Class resource frames: hiding
- Extra action button frame: skin, anchor, size - Extra action button frame: skin, anchor, size
- Instance swap frame: skin, anchor, font settings - Instance swap frame: skin, anchor, font settings
- Interface/Video/Audio options: skin the widgets ElvUI's own pass misses
- Only highlight unitframes if dispellable by your CoA class. - Only highlight unitframes if dispellable by your CoA class.
## Installation ## Installation
+42
View File
@@ -26,6 +26,11 @@ local defaults = {
vanityScale = 1, vanityScale = 1,
wardrobeScale = 1, wardrobeScale = 1,
}, },
-- Deliberately not inside the collections group: that switch covers
-- the three windows that share the Collections container and its tab
-- row, and this one is a separate window on UIParent with a tab row
-- of its own.
challenges = true,
}, },
extraActionButtonSize = 52, extraActionButtonSize = 52,
instanceButtonFont = "PT Sans Narrow", instanceButtonFont = "PT Sans Narrow",
@@ -274,6 +279,29 @@ local function getOptions()
}, },
}, },
}, },
challenges = {
order = 4,
type = "group",
name = "Challenges",
args = {
header = {
order = 1,
type = "header",
name = "Challenges",
},
enable = {
order = 2,
type = "toggle",
name = "Enable",
desc = "Skin the Challenges window and its tabs. Requires a UI reload.",
get = function() return CoA.db.profile.skins.challenges end,
set = function(_, value)
CoA.db.profile.skins.challenges = value
E:StaticPopup_Show("CONFIG_RL")
end,
},
},
},
}, },
}, },
classResources = { classResources = {
@@ -476,6 +504,20 @@ function CoA:Initialize()
self:InitializeWardrobeFrame() self:InitializeWardrobeFrame()
end end
end end
-- Its own switch rather than a place in the group above: the Challenges
-- window isn't reachable from the talent frame's tabs, so turning it off
-- doesn't leave a half-skinned set behind.
if self.InitializeChallengesFrame and skins.challenges then
self:InitializeChallengesFrame()
end
-- No switch of its own: this one only fills the gaps ElvUI's own Blizzard
-- options pass leaves, so it's on wherever that pass is, and its own gate on
-- E.private.skins.blizzard.enable is the same one ElvUI checks.
if self.InitializeInterfaceOptions then
self:InitializeInterfaceOptions()
end
end end
local function InitializeCallback() local function InitializeCallback()