Narcasung/Questie-X
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix arrow pointing to key-drop NPC after quest complete

Browse Source 
GetAllQuestIds called CheckQuestSourceItem(questId, true) for all
non-failed quests. When a consumable key is used and leaves the bag,
this created a fake 'get the item' objective pointing to the drop NPC
even when the quest was already complete (complete == 1).

Guard the call: only run CheckQuestSourceItem when complete != 1.
Complete quests route through PopulateObjectiveNotes which correctly
shows the finisher instead.
This commit is contained in:
Xurkon
2026-02-21 11:17:37 -06:00
parent 6600e57d30
commit 211bc5be84
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Modules/Quest/QuestieQuest.lua
+6 -1
View File
@@ -778,7 +778,12 @@ function QuestieQuest:GetAllQuestIds()
if complete == -1 then
QuestieQuest:UpdateQuest(questId)
else
QuestieQuest:CheckQuestSourceItem(questId, true)
-- Only draw the source item objective when the quest is not yet complete.
-- If the quest is complete (complete == 1), the source item was consumed during
-- the quest (e.g. Cold Iron Key for quest 12843) and should not draw its drop NPC.
if complete ~= 1 then
QuestieQuest:CheckQuestSourceItem(questId, true)
end
QuestieQuest:PopulateQuestLogInfo(quest)
if QuestieQuest:ShouldShowQuestNotes(questId) then