fix(tooltip): make Ascension quest-line stripping opt-in (#16)

HideAscensionQuestLines ran on every tooltip and removed any line matching a quest-objective pattern (N/M, [N] ...), clobbering other tooltip addons' lines (durability, stack counts, etc.). Gate it behind a new General-tab option 'Hide Ascension quest progress lines' (default off) so Questie no longer modifies tooltip lines it does not own by default. Existing installs read the unset option as off automatically.
2026-06-10 20:39:21 -05:00
parent cee005fc63
commit 49bc586c15
4 changed files with 18 additions and 0 deletions
@@ -45,6 +45,7 @@
 - **[Tooltip - ElvUI Style No Longer On By Default]** (#16) The "ElvUI tooltip style" option shipped enabled by default, so Questie restyled every default WoW tooltip — stripping the border — for users who never asked for it and don't run ElvUI. It is now opt-in (default off), and a one-time migration resets it off for existing installs so their default tooltips return. Users who want the flat style can re-enable it in the General tab.
 - **[Quest - Turned-In Quests Misclassified As Abandoned]** (#9) On Ascension some turn-ins (notably crafting/auto-complete quests) fire `QUEST_REMOVED` without a preceding `QUEST_TURNED_IN`, so Questie's 1-second abandon timer ran `MarkQuestAsAbandoned`. By then `QuestLogCache.RemoveQuest` had already cleared the quest, so the `IsComplete` check returned 0 and the *turned-in* quest was treated as abandoned — leaving its objective pins and turn-in `?` lingering on the map and minimap. The completion state is now snapshotted at `QUEST_REMOVED` time (while the quest is still in the cache) and used by the abandon timer, so a quest that was complete at removal is correctly completed (pins/`?` cleared) rather than abandoned.
 - **[Map - Minimap Range Cutoff No Longer Clips Visible Icons]** (#17) The "Minimap Icon Range Cutoff" added in a prior build hid every quest icon beyond its yard value *before* checking whether the icon was within the minimap's visible circle. Because the minimap's view radius is 133–466 yards depending on zoom, a cutoff of 100 (the default) hid icons that were clearly on the minimap — they only appeared once the player was very close. The cutoff now only clips icons that fall *outside* the minimap's visible radius: in HBD's pin renderer it is gated on `dist > 1` (outside the visible circle), and in `QuestieMap`'s minimap `FadeLogic` the effective cutoff is raised to at least the current minimap view radius (read from the new `HBDPins:GetMinimapRadius()`). Icons within the visible minimap always show again; the cutoff still controls how far edge-floating icons reach for far-apart objectives when zoomed out.
+- **[Tooltip - Ascension Quest-Line Stripping Now Opt-In]** (#16) `HideAscensionQuestLines` ran on every tooltip and removed any line matching a quest-objective pattern (`N/M`, `[N] ...`), which also stripped legitimate lines added by other tooltip addons (durability, stack counts, etc.) — so Questie still "aggressively overrode" tooltips even with the ElvUI style off. It is now gated behind a new General-tab option, **"Hide Ascension quest progress lines"** (default off), so by default Questie no longer modifies tooltip lines it doesn't own. Ascension users who want the server-injected quest-progress spam hidden can enable it.
 - **[Tooltip - Stop Eating ID Lines & Other Addons' Tooltip Text]** `HideAscensionQuestLines` (which hides Ascension's injected quest-objective progress text from tooltips) was too greedy: once it found an objective line (e.g. `0/8 Arcane Wraith slain`) it kept hiding every following non-indented line until an indented one. Because Questie's own `Item ID`/`NPC ID`/`Object ID` lines and other addons' additions (e.g. an item-count overlay) are appended at the *bottom* of the tooltip — after the objective block — a refresh pass wiped them too, so the ID you needed to report data never showed. It now hides only the lines that themselves match an Ascension objective pattern (`N/M`, `[N] ...`, `- N/M ...`) and never the trailing lines, so IDs and other addons' text are left intact.
 - **[Learner - Don't Purge NPCs With Useful State But No Spawns]** The `InjectLearnedData` purge loop was deleting entire NPC entries from `Questie.dbLearner.global.npcs` whenever `data[7]` (spawns) was empty, even if the entry still had a name, home zone, recorded kills, or quest references. This caused learner data to silently disappear on `/reload` for NPCs that had been learned but never killed in a position the learner could record (e.g. party-kill position attribution fix now passes nil coords for uncredited kills). Now only purges when ALL of name, zone, kills, and quest references are missing. Entries with other useful state get `data[7] = nil` instead so the row survives.
 - **[Learner - Import Shows Actual Spawn Coordinates Added]** The import completion message now shows how many spawn *coordinates* were really added (e.g. "Added 842 new spawn coordinates") rather than just entry counts. Counts `[7]` for NPCs and `[4]` for objects before and after the merge. A sparse export that merges entries but carries no coords means nothing new will appear on the map — the new message makes this clear.
@@ -436,6 +436,16 @@ function QuestieOptions.tabs.general:Initialize()
                        get = function () return Questie.db.profile.enableTooltips; end,
                        set = function (_, value) Questie.db.profile.enableTooltips = value end
                    },
+                    hideAscensionTooltipQuestLines = {
+                        type = "toggle",
+                        order = 8.15,
+                        name = function() return l10n('Hide Ascension quest progress lines'); end,
+                        desc = function() return l10n('Removes the quest-objective progress lines that the Ascension server injects into tooltips (e.g. "0/8 ..."). Off by default so Questie does not modify lines added by other tooltip addons.'); end,
+                        width = 1.5,
+                        disabled = function() return not Questie.db.profile.enableTooltips; end,
+                        get = function() return Questie.db.profile.hideAscensionTooltipQuestLines; end,
+                        set = function (_, value) Questie.db.profile.hideAscensionTooltipQuestLines = value end
+                    },
                    questsInNpcTooltip = {
                        type = "toggle",
                        order = 8.2,
@@ -89,6 +89,7 @@ function QuestieOptionsDefaults:Load()
            enableTooltipsQuestLevel = true,
            enableTooltipsSource = false,
            elvuiStyleTooltips = false,
+            hideAscensionTooltipQuestLines = false,
            showQuestXpAtMaxLevel = true,
            enableTooltipsNextInChain = true,
            learnerTooltips = true,
@@ -254,6 +254,12 @@ end

 function _QuestieTooltips:HideAscensionQuestLines(tooltip)
    if not Questie.db.profile.enableTooltips then return end
+    -- Opt-in only. This strips lines matching quest-objective patterns ("N/M", "[N] ...")
+    -- from tooltips to hide Ascension's server-injected quest progress. It runs on every
+    -- tooltip, so by default it must NOT touch them — otherwise it clobbers other tooltip
+    -- addons' lines that happen to look like "N/M" (durability, stack counts, etc.). Users
+    -- who want the Ascension quest-spam hidden can enable it explicitly. (#16)
+    if not Questie.db.profile.hideAscensionTooltipQuestLines then return end
    local numLines = tooltip:NumLines()
    if not numLines or numLines < 1 then return end