fix: implement tocVersion guard for GameVersionError.lua and update changelogs

This commit is contained in:
Xurkon
2026-03-18 17:52:38 -05:00
parent 35b581d6a9
commit 647981f8d8
3 changed files with 18 additions and 10 deletions
+3 -2
View File
@@ -2,11 +2,12 @@
## v1.3.4 — Taint Analysis & Error Fixes
*Resolves the `l10n` initialization error in `GameVersionError.lua` and confirms the integrity of the WotLKDB module after a deep taint analysis.*
*Resolves the initialization error in `GameVersionError.lua` and implements a version guard to support Classic-era private servers. Also confirms the integrity of the WotLKDB module after a deep taint analysis.*
### Core & Stability
- **[Fix]** Resolved `attempt to call local 'l10n' (a table value)` in `GameVersionError.lua` by using hardcoded English strings for early-load error messages.
- **[Fix]** Resolved `attempt to call local 'l10n' (a table value)` in `GameVersionError.lua` and implemented a `tocVersion` guard to prevent the "unsupported client" error on Classic-era private servers (e.g., Turtle WoW).
- **[Fix]** Updated `GameVersionError.lua` strings to correctly identify Questie-X as supporting Classic and private servers.
- **[Taint Analysis]** Completed a full audit of `Questie-X-WotLKDB`. No direct taint vectors or secure function overrides were found.
- **[Version Sync]** Synchronized versions to v1.3.4 across all components.
+12 -6
View File
@@ -1,22 +1,28 @@
---@type l10n
local l10n = QuestieLoader:ImportModule("l10n")
local _, _, _, tocVersion = GetBuildInfo()
if tocVersion and tocVersion < 50000 then
-- This is a Classic-era client (Turtle, Era, WotLK, etc.)
return
end
-- No timeres or other fancy stuff as 1.12 client is very limited.
-- StaticPopup has very limited width, so text is split to many lines.
local msg = {
"You're trying to use Questie addon",
"You're trying to use Questie-X",
"on an unsupported WoW game client!",
"WoW \"retail\" and private servers",
"are not supported.",
"WoW \"retail\" is NOT supported.",
"Please use a Classic-era client.",
"Questie only supports",
"WoW Classic (Era/Wrath)!",
"Questie-X only supports",
"WoW Classic (Vanilla/TBC/Wrath)!",
}
StaticPopupDialogs["QUESTIE_VERSION_ERROR"] = {
text = "|cffff0000ERROR|r\n" .. msg[1] .. "\n" .. msg[2] .. "\n\n" .. msg[3] .. "\n" .. msg[4] .. "\n\n" .. msg[5] .. "\n" .. msg[6],
text = "|cffff0000ERROR|r\n" .. msg[1] .. "\n" .. msg[2] .. "\n\n" .. msg[3] .. "\n" .. msg[4] .. "\n\n" .. msg[5] .. " " .. msg[6],
button2 = "OK",
hasEditBox = false,
whileDead = true
+3 -2
View File
@@ -177,11 +177,12 @@
<div class="container">
<h2 id="v134">v1.3.4 — Taint Analysis &amp; Error Fixes</h2>
<p><em>Resolves the <code>l10n</code> initialization error in <code>GameVersionError.lua</code> and confirms the integrity of the WotLKDB module after a deep taint analysis.</em></p>
<p><em>Resolves the initialization error in <code>GameVersionError.lua</code> and implements a version guard to support Classic-era private servers. Also confirms the integrity of the WotLKDB module after a deep taint analysis.</em></p>
<h3>Core &amp; Stability</h3>
<ul>
<li><strong>[Fix]</strong> Resolved <code>attempt to call local 'l10n' (a table value)</code> in <code>GameVersionError.lua</code> by using hardcoded English strings for early-load error messages.</li>
<li><strong>[Fix]</strong> Resolved <code>attempt to call local 'l10n' (a table value)</code> in <code>GameVersionError.lua</code> and implemented a <code>tocVersion</code> guard to prevent the "unsupported client" error on Classic-era private servers (e.g., Turtle WoW).</li>
<li><strong>[Fix]</strong> Updated <code>GameVersionError.lua</code> strings to correctly identify Questie-X as supporting Classic and private servers.</li>
<li><strong>[Taint Analysis]</strong> Completed a full audit of <code>Questie-X-WotLKDB</code>. No direct taint vectors or secure function overrides were found.</li>
<li><strong>[Version Sync]</strong> Synchronized versions to v1.3.4 across all components.</li>
</ul>