Commit Graph

544 Commits

Author SHA1 Message Date
Xurkon cd01a537f3 Merge branch 'tooltip-ascensiondb-precedence' into questie-learner-comms-improvements 2026-06-05 18:22:12 -05:00
Xurkon 7a87f51032 fix: skip malformed item objectives in cache 2026-06-05 18:02:15 -05:00
Xurkon aa973188ce fix: guard item name lookup against invalid ids 2026-06-05 17:55:52 -05:00
Xurkon 5d1fef9802 docs: document performance refactor status 2026-06-05 14:24:02 -05:00
Xurkon 9fcb1988da fix: preserve learner party kill updates 2026-06-05 14:19:42 -05:00
Xurkon b620b8ec87 docs: add performance refactor notice 2026-06-05 14:11:16 -05:00
Xurkon 1f6b6b14dc perf: align learner debounce defaults 2026-06-05 14:10:58 -05:00
Xurkon dd6fe75c52 docs: add performance refactor notice 2026-06-05 14:02:26 -05:00
Xurkon 3f3d2e65ac Revert "fix: add missing local profile in QuestieMap.ProcessQueue"
This reverts commit 2bdd1801c9.
2026-06-05 06:11:44 -05:00
Xurkon 2bdd1801c9 fix: add missing local profile in QuestieMap.ProcessQueue
ProcessQueue() references the global 'profile' at line 366 without
declaring it locally, causing 'attempt to index global profile (a nil)'
when called from the timer queue. All other functions in this file
declare local profile = Questie.db.profile before use.
2026-06-05 06:08:59 -05:00
Xurkon d1f79fd73e fix: prefer ascension tooltip data 2026-06-04 22:36:42 -05:00
Xurkon c85370de0b fix: replace select eight lookups 2026-06-04 21:58:54 -05:00
Xurkon f8b3972e70 fix: add lua 5.0 compatibility shims 2026-06-04 21:54:36 -05:00
Xurkon c3ea62f5bc fix: scope questie comms enable helper 2026-06-04 17:30:48 -05:00
Xurkon ccd2bc10d6 refactor: centralize performance options 2026-06-04 17:07:14 -05:00
Xurkon b62def52fd feat: add questie comms performance options 2026-06-04 17:05:03 -05:00
Xurkon a113791d64 perf: add questie comms disable gate 2026-06-04 17:04:12 -05:00
Xurkon c6bfa95c9e perf: wire questie comms throttles 2026-06-04 17:01:37 -05:00
Xurkon 5e3ac7cdd1 fix: synchronize learner performance options 2026-06-04 16:59:37 -05:00
Xurkon a1424bdd53 perf: add arrow performance controls 2026-06-04 16:53:21 -05:00
Xurkon 71a77b39d0 perf: cache arrow target coordinate lookups 2026-06-04 16:49:30 -05:00
Xurkon 8e90d43b6c perf: ignore bystander deaths for learner refreshes 2026-06-04 16:43:33 -05:00
Xurkon f160570a95 perf: add learner performance controls 2026-06-04 16:37:03 -05:00
Xurkon 305e918525 perf: batch learner pin refreshes 2026-06-04 16:23:43 -05:00
Xurkon 1ae4a21212 refactor: drop redundant learner private assignment 2026-06-04 10:03:26 -05:00
Xurkon 851a0ad6ea fix: capture learner event payload 2026-06-04 08:00:06 -05:00
Xurkon c4d9c2cf21 perf: head-tail quest comms queues 2026-06-04 07:42:31 -05:00
Xurkon bd1dfe7e79 perf: increment quest-list packet sizing 2026-06-04 07:33:47 -05:00
Xurkon 74d2095a72 perf: use head-index queues in learner comms 2026-06-04 07:24:01 -05:00
Xurkon 45357263c1 perf: batch learner merges and guard debug scans 2026-06-04 07:00:38 -05:00
Xurkon 51561b97d8 perf: batch learner updates and remove Turtle support 2026-06-04 06:47:45 -05:00
Azik 581634d199 Fix Ascension tracker line wrapping
Use tracker wrapping helpers that fall back when Ascension font strings do not expose GetNumLines or GetWrappedWidth.

(cherry picked from commit c9b7de2a636ca918c2549a13de87a688861c831f)
2026-06-03 06:50:07 -05:00
Xurkon 31864a467e fix: harden learner spawn suppression 2026-06-03 06:41:23 -05:00
Xurkon 4b7c295210 fix: stabilize minimap range cutoff and update release docs 2026-06-03 06:05:55 -05:00
Xurkon 93cfc17586 chore: remove minimal arrow assets 2026-06-03 01:49:05 -05:00
Xurkon e293f5b420 chore: exclude arrow backup snapshots from release archives 2026-06-03 00:39:55 -05:00
Xurkon f6ce9ac884 chore: untrack legacy root arrow assets 2026-06-03 00:36:00 -05:00
Xurkon c3b91f3bee fix: finalize arrow asset and docs updates 2026-06-03 00:26:39 -05:00
Xurkon 4fc8d661fd fix: clean faction arrow transparency 2026-06-02 13:03:19 -05:00
Xurkon 339dc1d94e fix: remove faction arrow alpha boxes 2026-06-02 12:52:18 -05:00
Xurkon 77857be339 fix: remove arcane arrow from bundle 2026-06-02 12:45:20 -05:00
Xurkon 02559f70bd feat: add horde and alliance arrow styles 2026-06-02 12:42:53 -05:00
Xurkon 8a41141172 feat: add new waypoint arrow styles 2026-06-02 12:18:48 -05:00
Xurkon 577efbe66b docs: mark v1.6.3 as released 2026-06-02 11:44:17 -05:00
Xurkon fe1f79cd2b chore: release 1.6.3 2026-06-02 11:25:28 -05:00
Xurkon d3c59e0ce8 feat(arrow): restore sprite sheet arrow from v1.6.2-test
- Swap single-frame SetRotation arrow back to 9x12 sprite sheet (512px TGA).
- Recompute cell UVs from bearing each frame via modulo math.
- Keep arrowold.tga on disk; routing to it comes in follow-up commit.
2026-06-01 21:17:31 -05:00
Xurkon 05d74cc432 feat(slash): add /radiusdebug and /terraindebug diagnostics
- Add /radiusdebug slash command. Dumps zoom, shape, size, scale,
  Minimap:GetViewRadius() (3.3.5a), C_Minimap.GetViewRadius()
  (Retail/WoTLK), CVars, fallback radius (outdoor/indoor), active
  pin count, and 8 sample pin metrics (screen offset, normalized
  radius, edge error). Includes an interpretation block.
- Add /terraindebug slash command. Dumps Minimap, MinimapCluster,
  zoom buttons, border, backdrop, north tag, compass texture,
  mask state, MMHolder, and 5 levels of parent chain. Detects
  ElvUI presence and prints interpretation hints.
- All API calls are defensive with pcall/conditional guards and
  tostring() fallbacks. Slash commands lazy-load _G.Questie*Debug
  so they work even if the function table is updated post-load.

These commands were used during the minimap drift investigation
to verify that radius, scale, and frame hierarchy were not the
drift source. They are invaluable for future regression
investigation and have zero runtime cost when not invoked.
2026-06-01 18:35:39 -05:00
Xurkon 8ee8c2516c fix(worldmap): persist button toggle; hook OnShow/OnHide; Mapster offset
- Refactor button positioning and visibility into _PositionMapButton and
  _RefreshMapButtonVisibility helpers. Single source of truth for both.
- WorldMapButton.Initialize now hooks OnShow/OnHide on WorldMapFrame so
  the button self-updates when the user opens/closes the world map.
  No more manual show/hide calls required from elsewhere in the code.
- Toggle(shouldShow) now persists to Questie.db.profile.mapShowHideEnabled
  and calls _RefreshMapButtonVisibility, so the user's choice survives
  /reload and is consistent with the world map's current visibility.
- Special-case Mapster offset: -50, -72.3 vs default -50, -40. Without
  this, the button overlapped Mapster's UI elements when both addons
  were loaded.
- Frame level set to 99 to ensure the button draws above other map
  elements.

All helpers are no-op-safe when mapButton is nil. IsAddOnLoaded
('Mapster') is optional — falls through to default offset if Mapster
is not loaded.
2026-06-01 18:35:39 -05:00
Xurkon 31ddb9a536 fix(quest): require multi-position learned spawns before overriding AscensionDB
- Add local _CountUniqueSpawnPositions helper (counts unique {x, y}
  across all zone buckets in a spawn table).
- Gate the prioritizeMyData check on ld.settings.enabled, matching the
  Database/QuestieDB.lua fix — when the learner is fully disabled,
  the override lookup is skipped entirely.
- Replace the NPC-15274-specific debug print in the monster() spawn
  selector with a universal reliability check: the learner data is
  only used when CountUniqueSpawnPositions(learnedSpawns) > 1.

This is the consumer-side enforcement of the QuestieLearner cleanup
(commit e71e072). Singleton-position spawn entries are typically the
player's current position captured during quest dialog (accept/turn-in)
rather than real kill evidence. By requiring at least 2 unique
positions, we avoid letting that pollution clobber AscensionDB curated
spawn data.

The NPC-15274-specific debug print was removed — the universal check
replaces it, and the diagnostic it provided is now expressed through
the Questie DEBUG_DEVELOP log line (which still emits when the new
condition is met).
2026-06-01 18:35:39 -05:00
Xurkon 515b1b2b33 fix(available): clean up pin and tooltip when quest enters quest log
In _CalculateAvailableQuests, when a quest is found in the quest log
(IsComplete ~= -1), explicitly unload any available-quest pin frame
for that questId, remove its tooltip, and clear the cached entry
before returning.

Previously the early-return left stale state behind: the pin frame
and tooltip would persist until the next sweep, causing a brief window
where the same quest was visible as both 'available' (yellow !) on
the map and 'in log' (yellow ?) in the quest log.

The cleanup order is correct: unload frame, then remove tooltip,
then clear cache. narrow scope (only 'available' data type) — does
not affect other pin categories.
2026-06-01 18:35:39 -05:00